Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 1160963003: GC Plugin: test destructor access of part object. (Closed)

Created:
5 years, 6 months ago by sof
Modified:
5 years, 6 months ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GC Plugin: test destructor access of part object. R=haraken BUG=496496 Committed: https://crrev.com/15fb740a49ab3660b8f8d496cfab2e4d37c7e6ca Cr-Commit-Position: refs/heads/master@{#333244}

Patch Set 1 #

Patch Set 2 : update expected output #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -7 lines) Patch
M tools/clang/blink_gc_plugin/tests/destructor_access_finalized_field.h View 1 2 chunks +14 lines, -0 lines 0 comments Download
M tools/clang/blink_gc_plugin/tests/destructor_access_finalized_field.cpp View 1 2 chunks +9 lines, -1 line 0 comments Download
M tools/clang/blink_gc_plugin/tests/destructor_access_finalized_field.txt View 1 1 chunk +6 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
sof
please take a look. Couldn't see coverage for this, so let's add some.
5 years, 6 months ago (2015-06-07 21:21:26 UTC) #2
haraken
LGTM
5 years, 6 months ago (2015-06-07 23:37:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1160963003/20001
5 years, 6 months ago (2015-06-08 06:16:41 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-08 06:26:24 UTC) #7
commit-bot: I haz the power
5 years, 6 months ago (2015-06-08 06:27:15 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/15fb740a49ab3660b8f8d496cfab2e4d37c7e6ca
Cr-Commit-Position: refs/heads/master@{#333244}

Powered by Google App Engine
This is Rietveld 408576698