tools/clang/blink_gc_plugin/tests/destructor_access_finalized_field.cpp - Issue 1160963003: GC Plugin: test destructor access of part object.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/clang/blink_gc_plugin/tests/destructor_access_finalized_field.cpp

Issue 1160963003: GC Plugin: test destructor access of part object. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: update expected output Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/clang/blink_gc_plugin/tests/destructor_access_finalized_field.h ('k') | tools/clang/blink_gc_plugin/tests/destructor_access_finalized_field.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/clang/blink_gc_plugin/tests/destructor_access_finalized_field.cpp

diff --git a/tools/clang/blink_gc_plugin/tests/destructor_access_finalized_field.cpp b/tools/clang/blink_gc_plugin/tests/destructor_access_finalized_field.cpp

index 79cbce77531701870fea354eb51ea4c8be52c71f..b6bbfd22e5d8750580d649c7a1888c4c2730076e 100644

--- a/tools/clang/blink_gc_plugin/tests/destructor_access_finalized_field.cpp

+++ b/tools/clang/blink_gc_plugin/tests/destructor_access_finalized_field.cpp

@@ -9,8 +9,10 @@ namespace blink {

HeapObject::~HeapObject()

{

// Valid access to fields.

- if (m_ref->foo() && !m_obj)

+ if (m_ref->foo() && !m_obj) {

m_objs.size();

+ m_part.obj();

+ }

// Invalid access to fields.

bar(m_obj);

@@ -22,6 +24,12 @@ void HeapObject::trace(Visitor* visitor)

{

visitor->trace(m_obj);

visitor->trace(m_objs);

+ visitor->trace(m_part);

+void PartOther::trace(Visitor* visitor)

+ visitor->trace(m_obj);

}