Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 1160883004: Keep workerStart timing info over request job restarts (Closed)

Created:
5 years, 6 months ago by Kunihiko Sakamoto
Modified:
5 years, 6 months ago
Reviewers:
horo
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org, kinuko+serviceworker, kinuko+watch
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Keep workerStart timing info over request job restarts In ServiceWorkerControlleeRequestHandler, job_ may be created multiple times, or cleared (for example, when the request falls back to network). In those cases, the workerStart timing info should hold the first time SW started for the request. This patch makes ServiceWorkerControlleeRequestHandler remember the workerStart time from the first job. BUG=465640 TEST=Will be added in https://codereview.chromium.org/1152673004/ Committed: https://crrev.com/9c6eec3e56dd43ec87bc486e17f6b9dfcb957af0 Cr-Commit-Position: refs/heads/master@{#331766}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
M content/browser/service_worker/service_worker_controllee_request_handler.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/service_worker/service_worker_controllee_request_handler.cc View 1 2 chunks +10 lines, -0 lines 0 comments Download
M content/browser/service_worker/service_worker_url_request_job.h View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Kunihiko Sakamoto
5 years, 6 months ago (2015-05-28 04:40:27 UTC) #2
horo
lgtm with nit https://codereview.chromium.org/1160883004/diff/1/content/browser/service_worker/service_worker_controllee_request_handler.cc File content/browser/service_worker/service_worker_controllee_request_handler.cc (right): https://codereview.chromium.org/1160883004/diff/1/content/browser/service_worker/service_worker_controllee_request_handler.cc#newcode68 content/browser/service_worker/service_worker_controllee_request_handler.cc:68: // save worker-start time of the ...
5 years, 6 months ago (2015-05-28 10:11:37 UTC) #3
Kunihiko Sakamoto
https://codereview.chromium.org/1160883004/diff/1/content/browser/service_worker/service_worker_controllee_request_handler.cc File content/browser/service_worker/service_worker_controllee_request_handler.cc (right): https://codereview.chromium.org/1160883004/diff/1/content/browser/service_worker/service_worker_controllee_request_handler.cc#newcode68 content/browser/service_worker/service_worker_controllee_request_handler.cc:68: // save worker-start time of the first job. On ...
5 years, 6 months ago (2015-05-28 10:21:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1160883004/20001
5 years, 6 months ago (2015-05-28 10:21:36 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-05-28 11:47:59 UTC) #8
commit-bot: I haz the power
5 years, 6 months ago (2015-05-28 11:48:53 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9c6eec3e56dd43ec87bc486e17f6b9dfcb957af0
Cr-Commit-Position: refs/heads/master@{#331766}

Powered by Google App Engine
This is Rietveld 408576698