Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3077)

Issue 1152673004: Add workerStart attribute to ResourceTiming (Closed)

Created:
5 years, 6 months ago by Kunihiko Sakamoto
Modified:
5 years, 6 months ago
Reviewers:
kinuko, tkent
CC:
blink-reviews, michaeln, jsbell+serviceworker_chromium.org, kenjibaheux+watch_chromium.org, arv+blink, vivekg_samsung, tzik, serviceworker-reviews, nhiroki, falken, vivekg, kinuko+serviceworker, Inactive, horo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Add workerStart attribute to ResourceTiming This patch adds workerStart attribute to PerformanceResourceTiming behind the experimental feature flag. This attribute allows developers to measure ServiceWorker startup time within the resource request, when the request is routed to a ServiceWorker. To enforce the attribute ordering, redirectStart and fetchStart now fall back to workerStart (if available) instead of startTime. spec: https://w3c.github.io/resource-timing/#widl-PerformanceResourceTiming-workerStart BUG=465640 TEST=http/tests/serviceworker/resource-timing.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196110

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -0 lines) Patch
A LayoutTests/http/tests/serviceworker/resource-timing.html View 1 chunk +58 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/serviceworker/resources/resource-timing-iframe.html View 1 chunk +4 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/serviceworker/resources/resource-timing-worker.js View 1 chunk +5 lines, -0 lines 0 comments Download
M Source/core/timing/PerformanceResourceTiming.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/timing/PerformanceResourceTiming.cpp View 2 chunks +14 lines, -0 lines 0 comments Download
M Source/core/timing/PerformanceResourceTiming.idl View 1 chunk +1 line, -0 lines 0 comments Download
M Source/platform/RuntimeEnabledFeatures.in View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Kunihiko Sakamoto
Kinuko-san, could you review this? Note: the test depends on https://codereview.chromium.org/1160883004/
5 years, 6 months ago (2015-05-28 06:47:42 UTC) #4
kinuko
lgtm
5 years, 6 months ago (2015-05-28 07:55:22 UTC) #5
Kunihiko Sakamoto
+tkent for Source/platform (runtime flag only)
5 years, 6 months ago (2015-05-28 07:59:13 UTC) #7
tkent
lgtm
5 years, 6 months ago (2015-05-28 08:04:10 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1152673004/40001
5 years, 6 months ago (2015-05-29 00:36:35 UTC) #10
commit-bot: I haz the power
5 years, 6 months ago (2015-05-29 02:11:39 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196110

Powered by Google App Engine
This is Rietveld 408576698