Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(656)

Unified Diff: runtime/observatory/tests/service/break_on_activation_test.dart

Issue 1160873002: Sundry service protocol cleanups before version 1.0. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: pre commit Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/tests/service/break_on_activation_test.dart
diff --git a/runtime/observatory/tests/service/break_on_activation_test.dart b/runtime/observatory/tests/service/break_on_activation_test.dart
index 0b20631d04e17565e9c4d65164815113d75d42b3..1a1573cf52fb57b118328e1e056bcc1ed879376b 100644
--- a/runtime/observatory/tests/service/break_on_activation_test.dart
+++ b/runtime/observatory/tests/service/break_on_activation_test.dart
@@ -64,12 +64,15 @@ var tests = [
}
});
- valueOfField(String name) {
- return rootLib.variables.singleWhere((v) => v.name == name).value;
+ valueOfField(String name) async {
+ var field = rootLib.variables.singleWhere((v) => v.name == name);
+ await field.load();
+ return field.staticValue;
+
}
- var r1Ref = valueOfField('r1');
- var r2Ref = valueOfField('r2');
- var r3Ref = valueOfField('r3');
+ var r1Ref = await valueOfField('r1');
+ var r2Ref = await valueOfField('r2');
+ var r3Ref = await valueOfField('r3');
var bpt1 = await isolate.addBreakOnActivation(r1Ref);
print("Added breakpoint $bpt1");
@@ -104,12 +107,14 @@ var tests = [
}
});
- valueOfField(String name) {
- return rootLib.variables.singleWhere((v) => v.name == name).value;
+ valueOfField(String name) async {
+ var field = rootLib.variables.singleWhere((v) => v.name == name);
+ await field.load();
+ return field.staticValue;
}
- var r1Ref = valueOfField('r1_named');
- var r2Ref = valueOfField('r2_named');
- var r3Ref = valueOfField('r3_named');
+ var r1Ref = await valueOfField('r1_named');
+ var r2Ref = await valueOfField('r2_named');
+ var r3Ref = await valueOfField('r3_named');
var bpt1 = await isolate.addBreakOnActivation(r1Ref);
print("Added breakpoint $bpt1");
@@ -144,12 +149,14 @@ var tests = [
}
});
- valueOfField(String name) {
- return rootLib.variables.singleWhere((v) => v.name == name).value;
+ valueOfField(String name) async {
+ var field = rootLib.variables.singleWhere((v) => v.name == name);
+ await field.load();
+ return field.staticValue;
}
- var r1Ref = valueOfField('r1');
- var r2Ref = valueOfField('r2');
- var r3Ref = valueOfField('r3');
+ var r1Ref = await valueOfField('r1');
+ var r2Ref = await valueOfField('r2');
+ var r3Ref = await valueOfField('r3');
var bpt1 = await isolate.addBreakOnActivation(r1Ref);
print("Added breakpoint $bpt1");
« no previous file with comments | « runtime/observatory/lib/src/service/object.dart ('k') | runtime/observatory/tests/service/contexts_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698