Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issue 1160683005: Add system crt dlls to win 2015 toolchain package (Closed)

Created:
5 years, 6 months ago by scottmg
Modified:
5 years, 6 months ago
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add system crt dlls to win 2015 toolchain package Based on some fiddling on a local VM (see bug), but possibly still insufficient. TBR=sebmarchand@chromium.org BUG=492774, 495944 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=295521

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -0 lines) Patch
M win_toolchain/package_from_installed.py View 1 chunk +33 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1160683005/1
5 years, 6 months ago (2015-06-03 22:44:08 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 6 months ago (2015-06-03 22:44:10 UTC) #4
scottmg
(This is a land of https://codereview.chromium.org/1154623007/ in a new issue due to recent moving around ...
5 years, 6 months ago (2015-06-03 22:45:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1160683005/1
5 years, 6 months ago (2015-06-03 22:46:05 UTC) #7
scottmg
On 2015/06/03 22:45:20, scottmg wrote: > (This is a land of https://codereview.chromium.org/1154623007/ in a new ...
5 years, 6 months ago (2015-06-03 22:46:26 UTC) #8
commit-bot: I haz the power
5 years, 6 months ago (2015-06-03 22:49:01 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=295521

Powered by Google App Engine
This is Rietveld 408576698