Add system crt dlls to win 2015 toolchain package

Add system crt dlls to win 2015 toolchain package

Based on some fiddling on a local VM (see bug), but possibly still insufficient.

R=sebmarchand@chromium.org
BUG=492774, 495944

[Sébastien Marchand, 2015-06-03 22:32:15]

lgtm
Le 2015-06-03 18:20, <scottmg@chromium.org> a écrit :

> Reviewers: Sébastien Marchand,
>
> Description:
> Add system crt dlls to win 2015 toolchain package
>
> Based on some fiddling on a local VM (see bug), but possibly still
> insufficient.
>
> R=sebmarchand@chromium.org
> BUG=492774, 495944
>
> Please review this at https://codereview.chromium.org/1154623007/
>
> Base URL:
> https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
>
> Affected files (+33, -0 lines):
>   M win_toolchain/package_from_installed.py
>
>
> Index: win_toolchain/package_from_installed.py
> diff --git a/win_toolchain/package_from_installed.py
> b/win_toolchain/package_from_installed.py
> index
>
6fe606f185c6418ccf9e7dcbf310d58b2c2abc39..f9d5502b73ec9748e8b7b181c20600f4ca087e42
> 100644
> --- a/win_toolchain/package_from_installed.py
> +++ b/win_toolchain/package_from_installed.py
> @@ -125,6 +125,39 @@ def BuildFileList():
>            to = os.path.join('ucrt', target, combined[len(src) + 1:])
>            result.append((combined, to))
>
> +    system_crt_files = [
> +        'api-ms-win-core-file-l1-2-0.dll',
> +        'api-ms-win-core-file-l2-1-0.dll',
> +        'api-ms-win-core-localization-l1-2-0.dll',
> +        'api-ms-win-core-processthreads-l1-1-1.dll',
> +        'api-ms-win-core-synch-l1-2-0.dll',
> +        'api-ms-win-core-timezone-l1-1-0.dll',
> +        'api-ms-win-core-xstate-l2-1-0.dll',
> +        'api-ms-win-crt-conio-l1-1-0.dll',
> +        'api-ms-win-crt-convert-l1-1-0.dll',
> +        'api-ms-win-crt-environment-l1-1-0.dll',
> +        'api-ms-win-crt-filesystem-l1-1-0.dll',
> +        'api-ms-win-crt-heap-l1-1-0.dll',
> +        'api-ms-win-crt-locale-l1-1-0.dll',
> +        'api-ms-win-crt-math-l1-1-0.dll',
> +        'api-ms-win-crt-multibyte-l1-1-0.dll',
> +        'api-ms-win-crt-private-l1-1-0.dll',
> +        'api-ms-win-crt-process-l1-1-0.dll',
> +        'api-ms-win-crt-runtime-l1-1-0.dll',
> +        'api-ms-win-crt-stdio-l1-1-0.dll',
> +        'api-ms-win-crt-string-l1-1-0.dll',
> +        'api-ms-win-crt-time-l1-1-0.dll',
> +        'api-ms-win-crt-utility-l1-1-0.dll',
> +        'api-ms-win-eventing-provider-l1-1-0.dll',
> +        'ucrtbase.dll',
> +        'ucrtbased.dll',
> +    ]
> +    for system_crt_file in system_crt_files:
> +        result.append((os.path.join(r'C:\Windows\SysWOW64',
> system_crt_file),
> +                       os.path.join('sys32', system_crt_file)))
> +        result.append((os.path.join(r'C:\Windows\System32',
> system_crt_file),
> +                       os.path.join('sys64', system_crt_file)))
> +
>    # Generically drop all arm stuff that we don't need.
>    return [(f, t) for f, t in result if 'arm\\' not in f.lower() and
>                                         'arm64\\' not in f.lower()]
>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[scottmg, 2015-06-03 22:32:26]

The CQ bit was checked by scottmg@chromium.org

[commit-bot: I haz the power, 2015-06-03 22:36:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-03 22:36:06]

Commit queue rejected this change because it did not recognize the base URL.
Please commit your change manually.

[scottmg, 2015-06-03 22:45:30]

On 2015/06/03 22:36:06, commit-bot: I haz the power wrote:
> Commit queue rejected this change because it did not recognize the base URL.
> Please commit your change manually.

Landing at https://codereview.chromium.org/1160683005/.