Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Issue 1160613004: Fold and remove SVGTextChunk (Closed)

Created:
5 years, 6 months ago by fs
Modified:
5 years, 6 months ago
Reviewers:
pdr., f(malita)
CC:
blink-reviews, blink-reviews-rendering, krit, eae+blinkwatch, f(malita), fs, gyuyoung2, jchaffraix+rendering, kouhei+svg_chromium.org, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Fold and remove SVGTextChunk Being the keeper of only some flags and a float, this class no longer provide much in terms of value. Folding it up into it's users, SVGText{,Path}ChunkBuilder gives less, and more straight-forward code. This can also be considered a first step towards untying 'textLength' from the chunk structure. BUG=486669 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196567

Patch Set 1 #

Patch Set 2 : Fixup exit-paths. #

Total comments: 2

Patch Set 3 : Switch again. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -154 lines) Patch
M Source/core/core.gypi View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
D Source/core/layout/svg/SVGTextChunk.h View 1 chunk +0 lines, -61 lines 0 comments Download
D Source/core/layout/svg/SVGTextChunk.cpp View 1 chunk +0 lines, -34 lines 0 comments Download
M Source/core/layout/svg/SVGTextChunkBuilder.cpp View 1 2 7 chunks +49 lines, -57 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
fs
5 years, 6 months ago (2015-06-04 10:23:08 UTC) #2
pdr.
So much cleaner! LGTM. https://codereview.chromium.org/1160613004/diff/20001/Source/core/layout/svg/SVGTextChunkBuilder.cpp File Source/core/layout/svg/SVGTextChunkBuilder.cpp (right): https://codereview.chromium.org/1160613004/diff/20001/Source/core/layout/svg/SVGTextChunkBuilder.cpp#newcode45 Source/core/layout/svg/SVGTextChunkBuilder.cpp:45: ETextAnchor textAnchor = style.svgStyle().textAnchor(); Nit: ...
5 years, 6 months ago (2015-06-04 20:22:02 UTC) #3
fs
https://codereview.chromium.org/1160613004/diff/20001/Source/core/layout/svg/SVGTextChunkBuilder.cpp File Source/core/layout/svg/SVGTextChunkBuilder.cpp (right): https://codereview.chromium.org/1160613004/diff/20001/Source/core/layout/svg/SVGTextChunkBuilder.cpp#newcode45 Source/core/layout/svg/SVGTextChunkBuilder.cpp:45: ETextAnchor textAnchor = style.svgStyle().textAnchor(); On 2015/06/04 20:22:02, pdr wrote: ...
5 years, 6 months ago (2015-06-05 08:42:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1160613004/40001
5 years, 6 months ago (2015-06-05 10:21:49 UTC) #7
commit-bot: I haz the power
5 years, 6 months ago (2015-06-05 10:25:15 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196567

Powered by Google App Engine
This is Rietveld 408576698