LayoutTests/fast/table/tr-min-content-crash.html - Issue 1160463004: Check if length isSpecified before accessing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/table/tr-min-content-crash.html

Issue 1160463004: Check if length isSpecified before accessing. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: LayoutTests/fast/table/tr-min-content-crash.html

diff --git a/LayoutTests/fast/table/tr-min-content-crash.html b/LayoutTests/fast/table/tr-min-content-crash.html

new file mode 100644

index 0000000000000000000000000000000000000000..2a8316f7301c24b11d2ef9d2f5762f7cd6869cd5

--- /dev/null

+++ b/LayoutTests/fast/table/tr-min-content-crash.html

@@ -0,0 +1,16 @@

+<!doctype html>

+<style>

+.min { height: -webkit-min-content; }

Julien - ping for review 2015/05/26 16:06:37 min-content would also work (and it's not prefixed

dsinclair 2015/05/27 15:20:06 The test does not crash if I use min-content.

+</style>

+<p>Test passes if it does not CRASH in debug.</p>

+<script>

+if (window.testRunner)

+ testRunner.dumpAsText();

+tr = document.createElementNS("http://www.w3.org/1999/xhtml", "tr");

Julien - ping for review 2015/05/26 16:06:37 No need for NameSpace here, createElement should w

dsinclair 2015/05/27 15:20:06 Done.

+tr.setAttribute("class", "min");

Julien - ping for review 2015/05/26 16:06:37 tr.style.height = "-webkit-min-content"; (eliminat

dsinclair 2015/05/27 15:20:06 Done.

+document.documentElement.appendChild(tr);

Julien - ping for review 2015/05/26 16:06:37 I really think we should just have the element alr

dsinclair 2015/05/27 15:20:06 Done.

+</script>