LayoutTests/fast/table/tr-min-content-crash.html - Issue 1160463004: Check if length isSpecified before accessing.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/table/tr-min-content-crash.html

Issue 1160463004: Check if length isSpecified before accessing. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 <!doctype html>

	2 <style>

	3 .min { height: -webkit-min-content; }
	Julien - ping for review 2015/05/26 16:06:37 min-content would also work (and it's not prefixed min-content would also work (and it's not prefixed). We should add tests for max-content and -webkit-fit-content too. dsinclair 2015/05/27 15:20:06 The test does not crash if I use min-content. Show quoted text On 2015/05/26 at 16:06:37, Julien Chaffraix - PST wrote: > min-content would also work (and it's not prefixed). > > We should add tests for max-content and -webkit-fit-content too. The test does not crash if I use min-content.
	4 </style>

	5

	6 <p>Test passes if it does not CRASH in debug.</p>

	7

	8 <script>

	9 if (window.testRunner)

	10 testRunner.dumpAsText();

	11

	12 tr = document.createElementNS("http://www.w3.org/1999/xhtml", "tr");
	Julien - ping for review 2015/05/26 16:06:37 No need for NameSpace here, createElement should w No need for NameSpace here, createElement should work. dsinclair 2015/05/27 15:20:06 Done. Show quoted text On 2015/05/26 at 16:06:37, Julien Chaffraix - PST wrote: > No need for NameSpace here, createElement should work. Done.
	13 tr.setAttribute("class", "min");
	Julien - ping for review 2015/05/26 16:06:37 tr.style.height = "-webkit-min-content"; (eliminat tr.style.height = "-webkit-min-content"; (eliminates the style sheet which is just noise) dsinclair 2015/05/27 15:20:06 Done. Show quoted text On 2015/05/26 at 16:06:37, Julien Chaffraix - PST wrote: > tr.style.height = "-webkit-min-content"; (eliminates the style sheet which is just noise) Done.
	14

	15 document.documentElement.appendChild(tr);
	Julien - ping for review 2015/05/26 16:06:37 I really think we should just have the element alr I really think we should just have the element already in the tree (we can keep the <style> element in this case) instead of doing an artificial appendChild. dsinclair 2015/05/27 15:20:06 Done. Show quoted text On 2015/05/26 at 16:06:37, Julien Chaffraix - PST wrote: > I really think we should just have the element already in the tree (we can keep the <style> element in this case) instead of doing an artificial appendChild. Done.
	16 </script>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/fast/table/tr-min-content-crash-expected.txt » ('j') | LayoutTests/fast/table/tr-min-content-crash-expected.txt » ('J')