Provide Point+Size, Point-Point, Point.toSize(), and Rect.toPoint().

Provide Point+Size, Point-Point, Point.toSize(), and Rect.toPoint().

Also some minor code cleanup in affected files and nearby files.

R=mpcomplete@chromium.org

Committed: https://chromium.googlesource.com/external/mojo/+/970c842210db041b18b280a18e686a56cef3a79d

[Matt Perry, 2015-06-03 21:15:25]

mpcomplete@chromium.org changed reviewers:
+ mpcomplete@chromium.org

[Matt Perry, 2015-06-03 21:15:25]

lgtm

https://codereview.chromium.org/1160453006/diff/1/sky/engine/core/painting/Re...
File sky/engine/core/painting/Rect.dart (right):

https://codereview.chromium.org/1160453006/diff/1/sky/engine/core/painting/Re...
sky/engine/core/painting/Rect.dart:47: bool contains(Point point) {
why this change?

https://codereview.chromium.org/1160453006/diff/1/sky/engine/core/painting/Re...
sky/engine/core/painting/Rect.dart:56: return false;
ditto?

Some of the formatting in this file was a result of running 'git cl format'. It
would be nice to be able to use that tool.

[Hixie, 2015-06-03 21:21:52]

Committed patchset #1 (id:1) manually as
970c842210db041b18b280a18e686a56cef3a79d (presubmit successful).

[Hixie, 2015-06-09 21:06:49]

https://codereview.chromium.org/1160453006/diff/1/sky/engine/core/painting/Re...
File sky/engine/core/painting/Rect.dart (right):

https://codereview.chromium.org/1160453006/diff/1/sky/engine/core/painting/Re...
sky/engine/core/painting/Rect.dart:47: bool contains(Point point) {
On 2015/06/03 at 21:15:25, Matt Perry wrote:
> why this change?

Consistency. When it fits on one line, =>, when it doesn't, { }. Having => split
over multiple lines looks really ugly to me.

But I am happy to go the other way if you like. :-)

https://codereview.chromium.org/1160453006/diff/1/sky/engine/core/painting/Re...
sky/engine/core/painting/Rect.dart:56: return false;
On 2015/06/03 at 21:15:25, Matt Perry wrote:
> ditto?
> 
> Some of the formatting in this file was a result of running 'git cl format'.
It would be nice to be able to use that tool.

Having the if statement on the same line as the statement it controls makes
reading the code confusing to me. But again, if the code style we prefer is the
other way around, I'm not going to fight it.