Provide Point+Size, Point-Point, Point.toSize(), and Rect.toPoint().

sky/engine/core/painting/Rect.dart

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 part of dart.sky;
 
 /// Holds 4 floating-point coordinates for a rectangle.
 class Rect {
   final Float32List _value = new Float32List(4);
   double get left => _value[0];
@@ skipping 26 matching lines @@
   }
 
   Point get upperLeft => new Point(left, top);
   Point get lowerRight => new Point(right, bottom);
   Point get center => new Point(left + right / 2.0, top + bottom / 2.0);
 
   Size get size => new Size(right - left, bottom - top);
 
   // Rects are inclusive of the top and left edges but exclusive of the bottom
   // right edges.
-  bool contains(Point point) =>
-      point.x >= left && point.x < right && point.y >= top && point.y < bottom;
+  bool contains(Point point) {

[Matt Perry, 2015/06/03 21:15:25]

why this change?

[Hixie, 2015/06/09 21:06:49]

Consistency. When it fits on one line, =>, when it doesn't, { }. Having => split
over multiple lines looks really ugly to me.

But I am happy to go the other way if you like. :-)

+    return point.x >= left && point.x < right && point.y >= top && point.y < bottom;
+  }
 
   bool operator ==(other) {
-    if (!(other is Rect)) return false;
+    if (other is! Rect)
+      return false;
     for (var i = 0; i < 4; ++i) {
-      if (_value[i] != other._value[i]) return false;
+      if (_value[i] != other._value[i])
+        return false;

[Matt Perry, 2015/06/03 21:15:25]

ditto?

Some of the formatting in this file was a result of running 'git cl format'. It
would be nice to be able to use that tool.

[Hixie, 2015/06/09 21:06:49]

Having the if statement on the same line as the statement it controls makes
reading the code confusing to me. But again, if the code style we prefer is the
other way around, I'm not going to fight it.

     }
     return true;
   }
+
   int get hashCode {
     return _value.fold(373, (value, item) => (37 * value + item.hashCode));
   }
-  String toString() => "Rect.LTRB($left, $top, $right, $bottom)";
+  String toString() => "Rect.fromLTRB($left, $top, $right, $bottom)";
 }