Issue 1160423003: Added jinja variable target_sdk_version to chrome_public_apk_manifest

Issue 1160423003: Added jinja variable target_sdk_version to chrome_public_apk_manifest (Closed)

Created:
5 years, 6 months ago by khushalsagar

Modified:
5 years, 6 months ago

Reviewers:
Yaron

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Added jinja variable target_sdk_version to chrome_public_apk_manifest BUG=492729 Committed: https://crrev.com/b89b329721005d0e5247308e6b0eaf721666f93d Cr-Commit-Position: refs/heads/master@{#333732}

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -2 lines)			Patch
M	chrome/android/BUILD.gn	View	1	1 chunk	+5 lines, -1 line	0 comments	Download
M	chrome/android/chrome_apk.gyp	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/android/java_staging/AndroidManifest.xml	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 8 (2 generated)

khushalsagar

On 2015/06/08 15:33:03, Yaron wrote: > lgtm but please also update gn Done.

5 years, 6 months ago (2015-06-09 18:59:24 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1160423003/20001

5 years, 6 months ago (2015-06-10 14:21:52 UTC) #6

commit-bot: I haz the power

5 years, 6 months ago (2015-06-10 14:54:00 UTC) #8

Message was sent while issue was closed.

Patchset 2 (id:??) landed as
https://crrev.com/b89b329721005d0e5247308e6b0eaf721666f93d
Cr-Commit-Position: refs/heads/master@{#333732}