Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3603)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/android/BUILD.gn

Issue 1160423003: Added jinja variable target_sdk_version to chrome_public_apk_manifest (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added change to gn Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/chrome_apk.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/BUILD.gn
diff --git a/chrome/android/BUILD.gn b/chrome/android/BUILD.gn
index 055e8edad49a8b1f01cc91d9c73d572379e68103..ad3f26896bbf7b5ad478cff9f143ac77c975814f 100644
--- a/chrome/android/BUILD.gn
+++ b/chrome/android/BUILD.gn
@@ -750,7 +750,11 @@ copy_ex("chrome_public_apk_assets") {
jinja_template("chrome_public_apk_manifest") {
input = "java_staging/AndroidManifest.xml"
output = "$root_gen_dir/chrome_public_apk_manifest/AndroidManifest.xml"
- variables = jinja_variables + [ "min_sdk_version=16" ]
+ variables = jinja_variables
+ variables += [
+ "min_sdk_version=16",
+ "target_sdk_version=22",
+ ]
}
# GYP: //chrome/android/chrome_apk.gyp:chrome_public_template_resources
« no previous file with comments | « no previous file | chrome/android/chrome_apk.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698