Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1157)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: Source/modules/app_banner/BeforeInstallPromptEvent.idl

Issue 1160413004: Add hooks for BeforeInstallPromptEvent to be redispatched. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Making prompt() return a promise Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« Source/modules/app_banner/BeforeInstallPromptEvent.cpp ('K') | « Source/modules/app_banner/BeforeInstallPromptEvent.cpp ('k') | public/platform/modules/app_banner/WebAppBannerClient.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/app_banner/BeforeInstallPromptEvent.idl
diff --git a/Source/modules/app_banner/BeforeInstallPromptEvent.idl b/Source/modules/app_banner/BeforeInstallPromptEvent.idl
index 30f2a7f5415f1a80e4ec99dd60b422a7b8b1748e..6199f89c77b3cfb8823da86ef4ed9c6c3314a0d8 100644
--- a/Source/modules/app_banner/BeforeInstallPromptEvent.idl
+++ b/Source/modules/app_banner/BeforeInstallPromptEvent.idl
@@ -8,4 +8,6 @@
] interface BeforeInstallPromptEvent : Event {
readonly attribute sequence<DOMString> platforms;
[CallWith=ScriptState] readonly attribute Promise<DOMString> userChoice;
+
+ [CallWith=ScriptState] Promise<DOMString> prompt();
mlamouri (slow - plz ping) 2015/06/11 00:42:17 Why Promise<DOMString>?
};
« Source/modules/app_banner/BeforeInstallPromptEvent.cpp ('K') | « Source/modules/app_banner/BeforeInstallPromptEvent.cpp ('k') | public/platform/modules/app_banner/WebAppBannerClient.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698