Source/modules/app_banner/BeforeInstallPromptEvent.idl - Issue 1160413004: Add hooks for BeforeInstallPromptEvent to be redispatched.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/modules/app_banner/BeforeInstallPromptEvent.idl

Issue 1160413004: Add hooks for BeforeInstallPromptEvent to be redispatched. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Making prompt() return a promise Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« Source/modules/app_banner/BeforeInstallPromptEvent.cpp ('K') | « Source/modules/app_banner/BeforeInstallPromptEvent.cpp ('k') | public/platform/modules/app_banner/WebAppBannerClient.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2015 The Chromium Authors. All rights reserved.	1 // Copyright 2015 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 [	5 [

6 Constructor(DOMString type, optional BeforeInstallPromptEventInit eventInitD ict),	6 Constructor(DOMString type, optional BeforeInstallPromptEventInit eventInitD ict),

7 RuntimeEnabled=AppBanner,	7 RuntimeEnabled=AppBanner,

8 ] interface BeforeInstallPromptEvent : Event {	8 ] interface BeforeInstallPromptEvent : Event {

9 readonly attribute sequence<DOMString> platforms;	9 readonly attribute sequence<DOMString> platforms;

10 [CallWith=ScriptState] readonly attribute Promise<DOMString> userChoice;	10 [CallWith=ScriptState] readonly attribute Promise<DOMString> userChoice;

	11

	12 [CallWith=ScriptState] Promise<DOMString> prompt();
	mlamouri (slow - plz ping) 2015/06/11 00:42:17 Why Promise<DOMString>? Why Promise<DOMString>?
11 };	13 };

OLD	NEW