Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1057)

Issue 1160253006: Rename LifecycleObserver<T>::dispose() as clearContext() (Closed)

Created:
5 years, 6 months ago by sof
Modified:
5 years, 6 months ago
Reviewers:
haraken
CC:
blink-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Rename LifecycleObserver<T>::dispose() as clearContext() Have the name of this helper match what it does; dispose() is too generic. Observer instances only need to clear out their context and rarely, so tighten up the visibility accordingly. R=haraken BUG=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196502

Patch Set 1 #

Patch Set 2 : rename as clearContext() #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M Source/core/animation/Animation.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/AsyncCallTracker.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/LifecycleObserver.h View 1 3 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
sof
please take a look. Resolving calls to dispose() from classes that inherit LifecycleObserver<> is harder ...
5 years, 6 months ago (2015-06-04 12:12:41 UTC) #2
haraken
LGTM
5 years, 6 months ago (2015-06-04 12:44:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1160253006/20001
5 years, 6 months ago (2015-06-04 12:51:28 UTC) #5
commit-bot: I haz the power
5 years, 6 months ago (2015-06-04 13:56:42 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196502

Powered by Google App Engine
This is Rietveld 408576698