Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 1160233002: Fix an issue where Chrome doesn't always restart from chrome://flags. (Closed)

Created:
5 years, 6 months ago by Maria
Modified:
5 years, 6 months ago
Reviewers:
Ted C
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix an issue where Chrome doesn't always restart from chrome://flags. The issue is that the Android system may take a long time to call onDestroy on the activities, which is the signal we are currently looking for. Give it a second to clean up instead and kill it regardless if it's still not done. BUG=486951 Committed: https://crrev.com/18d9c28b4bdc452a9b9ff90d3873f92ab2c7b978 Cr-Commit-Position: refs/heads/master@{#332089}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -2 lines) Patch
M chrome/android/java_staging/src/org/chromium/chrome/browser/ChromeLifetimeController.java View 4 chunks +16 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Maria
5 years, 6 months ago (2015-05-30 00:01:38 UTC) #2
Ted C
lgtm
5 years, 6 months ago (2015-05-30 00:04:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1160233002/1
5 years, 6 months ago (2015-05-30 00:06:38 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-05-30 00:43:51 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-05-30 00:44:43 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/18d9c28b4bdc452a9b9ff90d3873f92ab2c7b978
Cr-Commit-Position: refs/heads/master@{#332089}

Powered by Google App Engine
This is Rietveld 408576698