Issue 1160213002: Clang package.py: fix list append vs. extend mistake

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1160213002: Clang package.py: fix list append vs. extend mistake (Closed)

Created:
5 years, 6 months ago by hans

Modified:
5 years, 6 months ago

Reviewers:
Nico

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	tools/clang/scripts/package.py	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 7 (2 generated)

Nico

lgtm At some point, we (I) probably should probably write some tests for this. Now ...

5 years, 6 months ago (2015-05-29 23:43:32 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1160213002/1

5 years, 6 months ago (2015-05-30 00:10:38 UTC) #5

commit-bot: I haz the power

Patchset 1 (id:??) landed as https://crrev.com/02b35ff98512c090edcd9694477318ad866a465b Cr-Commit-Position: refs/heads/master@{#332086}

5 years, 6 months ago (2015-05-30 00:28:35 UTC) #6

hans

5 years, 6 months ago (2015-05-30 00:28:46 UTC) #7

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
02b35ff98512c090edcd9694477318ad866a465b (presubmit successful).