Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(920)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1160203002: Make Dispatcher::Type an enum class. (Closed)

Created:
5 years, 6 months ago by viettrungluu
Modified:
5 years, 6 months ago
Reviewers:
yzshen1
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Make Dispatcher::Type an enum class. * It's not clear if I should make it sized (as int32_t) or not, so I left it unsized for now. * I made the various operator<< inline, and added a missing export macro. (Everything ends up including <ostream> anyway.) * Being strongly typed means that I found a non-sensical static_cast in dispatcher.cc. R=yzshen@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/21cd515c016bf4df042d9c9aa8fc62dc1d715ef1

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -67 lines) Patch
M mojo/edk/embedder/embedder.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/edk/system/channel_endpoint_id.h View 1 chunk +3 lines, -2 lines 0 comments Download
M mojo/edk/system/core_test_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/edk/system/data_pipe_consumer_dispatcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/edk/system/data_pipe_impl_unittest.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M mojo/edk/system/data_pipe_producer_dispatcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/edk/system/dispatcher.h View 3 chunks +14 lines, -7 lines 0 comments Download
M mojo/edk/system/dispatcher.cc View 1 chunk +7 lines, -7 lines 0 comments Download
M mojo/edk/system/dispatcher_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/edk/system/message_in_transit.h View 2 chunks +14 lines, -5 lines 0 comments Download
M mojo/edk/system/message_in_transit.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M mojo/edk/system/message_pipe.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/edk/system/message_pipe_dispatcher.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M mojo/edk/system/message_pipe_dispatcher_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/edk/system/multiprocess_message_pipe_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/edk/system/platform_handle_dispatcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/edk/system/platform_handle_dispatcher_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M mojo/edk/system/remote_data_pipe_impl_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M mojo/edk/system/remote_message_pipe_unittest.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M mojo/edk/system/shared_buffer_dispatcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/edk/system/shared_buffer_dispatcher_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M mojo/edk/system/simple_dispatcher_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/edk/system/transport_data.h View 1 chunk +2 lines, -1 line 1 comment Download
M mojo/edk/system/transport_data.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
viettrungluu
5 years, 6 months ago (2015-05-29 22:54:02 UTC) #1
yzshen1
lgtm https://codereview.chromium.org/1160203002/diff/1/mojo/edk/system/transport_data.h File mojo/edk/system/transport_data.h (right): https://codereview.chromium.org/1160203002/diff/1/mojo/edk/system/transport_data.h#newcode165 mojo/edk/system/transport_data.h:165: // TODO(vtl): Should I make |Dispatcher::Type| an |int32_t| ...
5 years, 6 months ago (2015-06-01 15:48:17 UTC) #2
viettrungluu
On 2015/06/01 15:48:17, yzshen1 wrote: > lgtm > > https://codereview.chromium.org/1160203002/diff/1/mojo/edk/system/transport_data.h > File mojo/edk/system/transport_data.h (right): > ...
5 years, 6 months ago (2015-06-02 17:14:05 UTC) #3
viettrungluu
5 years, 6 months ago (2015-06-02 17:15:44 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
21cd515c016bf4df042d9c9aa8fc62dc1d715ef1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698