Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1433)

Unified Diff: mojo/edk/system/transport_data.cc

Issue 1160203002: Make Dispatcher::Type an enum class. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« mojo/edk/system/transport_data.h ('K') | « mojo/edk/system/transport_data.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/edk/system/transport_data.cc
diff --git a/mojo/edk/system/transport_data.cc b/mojo/edk/system/transport_data.cc
index 24b49ec091eac0d338efa60ce860c31ad02eace6..783a51d6eb0d810c64277bd0ad27c4589725cfe6 100644
--- a/mojo/edk/system/transport_data.cc
+++ b/mojo/edk/system/transport_data.cc
@@ -137,8 +137,8 @@ TransportData::TransportData(scoped_ptr<DispatcherVector> dispatchers,
for (size_t i = 0; i < num_handles; i++) {
Dispatcher* dispatcher = (*dispatchers)[i].get();
if (!dispatcher) {
- static_assert(Dispatcher::kTypeUnknown == 0,
- "Value of Dispatcher::kTypeUnknown must be 0");
+ static_assert(static_cast<int32_t>(Dispatcher::Type::UNKNOWN) == 0,
+ "Value of Dispatcher::Type::UNKNOWN must be 0");
continue;
}
@@ -166,7 +166,7 @@ TransportData::TransportData(scoped_ptr<DispatcherVector> dispatchers,
#endif
} else {
// Nothing to do on failure, since |buffer_| was cleared, and
- // |kTypeUnknown| is zero. The handle was simply closed.
+ // |Type::UNKNOWN| is zero. The handle was simply closed.
LOG(ERROR) << "Failed to serialize handle to remote message pipe";
}
« mojo/edk/system/transport_data.h ('K') | « mojo/edk/system/transport_data.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698