Vector ICs: ClassLiterals need to allocate a vector slot for home objects.

Vector ICs: ClassLiterals need to allocate a vector slot for home objects.

BUG=

Committed: https://crrev.com/b27016b78a7dd58dc682eed51500ba603b3e46b0
Cr-Commit-Position: refs/heads/master@{#28827}

[mvstanton, 2015-06-05 07:13:46]

mvstanton@chromium.org changed reviewers:
+ jkummerow@chromium.org

[mvstanton, 2015-06-05 07:13:47]

Hi Jakob,
In testing, I found one AST node that didn't have the required slot support for
store ics. This addresses that oversight...ClassLiteral works similarly to
ObjectLiteral, just a bit simpler.

Thanks for the look!
--Michael

[arv (Not doing code reviews), 2015-06-05 14:05:03]

I assume we have a similar issue here?

https://code.google.com/p/chromium/codesearch#chromium/src/v8/src/runtime/run...

[mvstanton, 2015-06-08 08:08:46]

Hi Erik,
I think we'll have an issue there when we are using an IC, then we'll need a
slot. Until then, calls to the runtime functions to store the property don't
need a slot. My impression is that ES6 support will gradually want more ICs?

[Jakob Kummerow, 2015-06-08 08:27:28]

LGTM.

https://codereview.chromium.org/1160173004/diff/1/src/ast.cc
File src/ast.cc (right):

https://codereview.chromium.org/1160173004/diff/1/src/ast.cc#newcode302
src/ast.cc:302: // ics must mirror FullCodeGenerator::VisitClassLiteral.
nit: s/ics/ICs/

https://codereview.chromium.org/1160173004/diff/1/src/ia32/full-codegen-ia32.cc
File src/ia32/full-codegen-ia32.cc (right):

https://codereview.chromium.org/1160173004/diff/1/src/ia32/full-codegen-ia32....
src/ia32/full-codegen-ia32.cc:2480: // store_slot_index points to the vector ic
slot for the next store ic used.
s/ic/IC/g

[mvstanton, 2015-06-08 08:38:42]

The CQ bit was checked by mvstanton@chromium.org

[mvstanton, 2015-06-08 08:38:43]

The patchset sent to the CQ was uploaded after l-g-t-m from
jkummerow@chromium.org
Link to the patchset: https://codereview.chromium.org/1160173004/#ps40001
(title: "REBASE.")

[commit-bot: I haz the power, 2015-06-08 08:38:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1160173004/40001

[mvstanton, 2015-06-08 08:39:13]

Thx very much! Submitting...

https://codereview.chromium.org/1160173004/diff/1/src/ast.cc
File src/ast.cc (right):

https://codereview.chromium.org/1160173004/diff/1/src/ast.cc#newcode302
src/ast.cc:302: // ics must mirror FullCodeGenerator::VisitClassLiteral.
On 2015/06/08 08:27:28, Jakob wrote:
> nit: s/ics/ICs/

Done.

https://codereview.chromium.org/1160173004/diff/1/src/ia32/full-codegen-ia32.cc
File src/ia32/full-codegen-ia32.cc (right):

https://codereview.chromium.org/1160173004/diff/1/src/ia32/full-codegen-ia32....
src/ia32/full-codegen-ia32.cc:2480: // store_slot_index points to the vector ic
slot for the next store ic used.
On 2015/06/08 08:27:28, Jakob wrote:
> s/ic/IC/g

Done, also in a similar comment in VisitObjectLiteral.

[commit-bot: I haz the power, 2015-06-08 10:10:16]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-06-08 10:10:23]

Patchset 3 (id:??) landed as
https://crrev.com/b27016b78a7dd58dc682eed51500ba603b3e46b0
Cr-Commit-Position: refs/heads/master@{#28827}