[1/5 chromium] Shows the clients which are controlled by ServiceWorker in DevTools.

content/browser/devtools/protocol/service_worker_handler.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/devtools/protocol/service_worker_handler.h"
 
 #include "base/bind.h"
 #include "base/containers/scoped_ptr_hash_map.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/utf_string_conversions.h"
@@ skipping 379 matching lines @@
     return CreateContextErrorResponse();
   int64 id = 0;
   if (!base::StringToInt64(registration_id, &id))
     return CreateInvalidVersionIdErrorResponse();
   BrowserContext::DeliverPushMessage(
       render_frame_host_->GetProcess()->GetBrowserContext(), GURL(origin), id,
       data, base::Bind(&PushDeliveryNoOp));
   return Response::OK();
 }
 
+Response ServiceWorkerHandler::GetClientInfo(DevToolsCommandId command_id,
+                                             const std::string& client_id) {
+  return Response::InternalError("Not implemented yet");

[pfeldman, 2015/06/05 12:19:54]

Why do you need command_id?

[horo, 2015/06/08 03:21:53]

"getTargetInfo" doesn't need to be "async" command.
It should be "sync" command like "GetTargetInfo(const std::string& target_id,
scoped_refptr<TargetInfo>* target_info)".
But I can't use TargetInfo type in service_worker_handler.* before it will be
defined in protocol.json and be used in a command which handler is "browser".

So (1) this cl introduces a dummy "async" method in service_worker_handler.*,
and (2) https://codereview.chromium.org/1151993003/ defines TargetInfo and an
"async" command in protocol.json, and (3)
https://codereview.chromium.org/1149383004/ introduces "sync" command in
service_worker_handler.*, and (4) https://codereview.chromium.org/1164583002/
removes '"async": true' from protocol.json, and (5)
https://codereview.chromium.org/1143363009/ removes "async" method from
service_worker_handler.*.

+}
+
+Response ServiceWorkerHandler::FocusClient(const std::string& client_id) {
+  scoped_refptr<DevToolsAgentHost> agent_host(
+      DevToolsAgentHost::GetForId(client_id));
+  if (!agent_host) {

[pfeldman, 2015/06/05 12:19:54]

drop {}

[horo, 2015/06/08 03:21:53]

Done.

+    return Response::InvalidParams("clientId");
+  }
+  agent_host->Activate();
+  return Response::OK();
+}
+
 void ServiceWorkerHandler::OpenNewDevToolsWindow(int process_id,
                                                  int devtools_agent_route_id) {
   scoped_refptr<DevToolsAgentHostImpl> agent_host(
       ServiceWorkerDevToolsManager::GetInstance()
           ->GetDevToolsAgentHostForWorker(process_id, devtools_agent_route_id));
   if (!agent_host.get())
     return;
   agent_host->Inspect(render_frame_host_->GetProcess()->GetBrowserContext());
 }
 
@@ skipping 107 matching lines @@
     return;
   host->DetachClient();
   client_->WorkerTerminated(WorkerTerminatedParams::Create()->
       set_worker_id(host->GetId()));
   attached_hosts_.erase(it);
 }
 
 }  // namespace service_worker
 }  // namespace devtools
 }  // namespace content