Issue 1160093005: Turn on ui impl-side painting by default

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1160093005: Turn on ui impl-side painting by default (Closed)

Created:
5 years, 6 months ago by enne (OOO)

Modified:
5 years, 6 months ago

Reviewers:
danakj, weiliangc

CC:
cc-bugs_chromium.org, chromium-reviews, danakj+watch_chromium.org, davemoore+watch_chromium.org, dzhioev+watch_chromium.org, jbauman+watch_chromium.org, kalyank, oshima+watch_chromium.org, piman+watch_chromium.org, sievers+watch_chromium.org, stevenjb+watch_chromium.org, Ian Vollick

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Turn on ui impl-side painting by default Turn on impl-side painting on Aura browser compositor by default and add a disable compositor switch. Previously turned on/reverted here: https://codereview.chromium.org/962833003 R=danakj@chromium.org,weiliangc@chromium.org BUG=314185

Patch Set 1 #

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+6 lines, -4 lines)			Patch
M	chrome/browser/chromeos/login/screenshot_testing/screenshot_testing_mixin.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	ui/compositor/compositor_switches.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ui/compositor/compositor_switches.cc	View	2 chunks	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

danakj

Hm. Bunch of pixel test failures?? Well if this isn't failing tests again /o\ then ...

5 years, 6 months ago (2015-05-30 00:10:07 UTC) #3

weiliangc

LGTM \o/ Also I sent another try bot run for mac_chromium_rel_ng. :)

5 years, 6 months ago (2015-06-01 14:46:53 UTC) #4

weiliangc

5 years, 6 months ago (2015-06-01 16:44:26 UTC) #5

The try bot pixel test failures
(http://chromium-browser-gpu-tests.commondatastorage.googleapis.com/view_test_...)
looks like a scale was not applied?

Expand Messages | Collapse Messages