Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 1160093002: [arm] Fix vmov immediate for ARMv6. (Closed)

Created:
5 years, 6 months ago by Rodolph Perfetta (ARM)
Modified:
5 years, 6 months ago
Reviewers:
Benedikt Meurer, ulan
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[arm] Fix vmov immediate for ARMv6. vmov immediate was always emitting movt for some immediates wether or not the CPU supported ARMv7. BUG=v8:4019 LOG=n Committed: https://crrev.com/81703350bbb9923d211fe5b79e90bd458b0916e2 Cr-Commit-Position: refs/heads/master@{#28691}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M src/arm/assembler-arm.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Rodolph Perfetta (ARM)
5 years, 6 months ago (2015-05-28 18:10:38 UTC) #2
Benedikt Meurer
lgtm
5 years, 6 months ago (2015-05-29 05:06:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1160093002/1
5 years, 6 months ago (2015-05-29 05:06:48 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-05-29 05:31:30 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-05-29 05:31:51 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/81703350bbb9923d211fe5b79e90bd458b0916e2
Cr-Commit-Position: refs/heads/master@{#28691}

Powered by Google App Engine
This is Rietveld 408576698