chrome/browser/ui/window_sizer/window_sizer_ash_uitest.cc - Issue 1160073004: chrome/browser/ui: Remove use of MessageLoopProxy and deprecated MessageLoop APIs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/window_sizer/window_sizer_ash_uitest.cc

Issue 1160073004: chrome/browser/ui: Remove use of MessageLoopProxy and deprecated MessageLoop APIs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Check for task runner instead of current message loop. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/webui/local_discovery/local_discovery_ui_browsertest.cc ('K') | « chrome/browser/ui/webui/signin/user_manager_screen_handler.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/window_sizer/window_sizer_ash_uitest.cc

diff --git a/chrome/browser/ui/window_sizer/window_sizer_ash_uitest.cc b/chrome/browser/ui/window_sizer/window_sizer_ash_uitest.cc

index fb0988e3bf55ef979fc298f55c46e8963713e0f3..e59d182a2975bf1b825e68373d4d962202a11054 100644

--- a/chrome/browser/ui/window_sizer/window_sizer_ash_uitest.cc

+++ b/chrome/browser/ui/window_sizer/window_sizer_ash_uitest.cc

@@ -7,7 +7,9 @@

#include "ash/shell.h"

#include "ash/test/shelf_test_api.h"

#include "base/command_line.h"

-#include "base/message_loop/message_loop.h"

+#include "base/location.h"

+#include "base/single_thread_task_runner.h"

+#include "base/thread_task_runner_handle.h"

#include "chrome/browser/lifetime/application_lifetime.h"

#include "chrome/browser/ui/browser.h"

#include "chrome/browser/ui/browser_list.h"

@@ -141,9 +143,8 @@ class WindowSizerContextMenuTest : public WindowSizerTest {

}

static void QuitLoop() {

- base::MessageLoop::current()->PostTask(

- FROM_HERE,

- base::MessageLoop::QuitWhenIdleClosure());

+ base::ThreadTaskRunnerHandle::Get()->PostTask(

+ FROM_HERE, base::MessageLoop::QuitWhenIdleClosure());

msw 2015/06/10 00:12:58 Is this still correct? Maybe update the QuitLoop()

Sami 2015/06/10 12:35:34 Yes, this is still exiting the message loop for th

}

private: