chrome/browser/ui: Remove use of MessageLoopProxy and deprecated MessageLoop APIs

chrome/browser/ui/window_sizer/window_sizer_ash_uitest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/shelf/shelf.h"
 #include "ash/shelf/shelf_view.h"
 #include "ash/shell.h"
 #include "ash/test/shelf_test_api.h"
 #include "base/command_line.h"
-#include "base/message_loop/message_loop.h"
+#include "base/location.h"
+#include "base/single_thread_task_runner.h"
+#include "base/thread_task_runner_handle.h"
 #include "chrome/browser/lifetime/application_lifetime.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_list.h"
 #include "chrome/browser/ui/browser_window.h"
 #include "chrome/test/base/in_process_browser_test.h"
 #include "ui/aura/window_event_dispatcher.h"
 #include "ui/base/test/ui_controls.h"
 #include "ui/events/test/event_generator.h"
 #include "ui/views/controls/menu/menu_controller.h"
 #include "ui/views/view.h"
@@ skipping 12 matching lines @@
     command_line->AppendSwitchASCII("ash-host-window-bounds",
                                     "600x600,601+0-600x600");
   }
 
  private:
   DISALLOW_COPY_AND_ASSIGN(WindowSizerTest);
 };
 
 void CloseBrowser(Browser* browser) {
   browser->window()->Close();
   base::MessageLoop::current()->RunUntilIdle();

[msw, 2015/06/10 00:12:58]

Is this correct? Please check other files for base::MessageLoop::current().

[Sami, 2015/06/10 12:35:34]

Yes, this is still correct[1]: you can't call Run on a SingleThreadTaskRunner
which is why this operation needs to be done directly on the MessageLoop.

[1] Although deprecated too but not the subject of this patch :)

 }
 
 gfx::Rect GetChromeIconBoundsForRootWindow(aura::Window* root_window) {
   ash::Shelf* shelf = ash::Shelf::ForWindow(root_window);
   const ash::ShelfView* shelf_view =
       ash::test::ShelfTestAPI(shelf).shelf_view();
   const views::ViewModel* view_model = shelf_view->view_model_for_test();
 
   EXPECT_EQ(2, view_model->view_size());
   return view_model->view_at(1)->GetBoundsInScreen();
@@ skipping 80 matching lines @@
         base::Bind(&WindowSizerContextMenuTest::Step3));
   }
 
   static void Step3() {
     ui_controls::SendMouseEventsNotifyWhenDone(
         ui_controls::RIGHT, ui_controls::UP,
         base::Bind(&WindowSizerContextMenuTest::QuitLoop));
   }
 
   static void QuitLoop() {
-    base::MessageLoop::current()->PostTask(
-        FROM_HERE,
-        base::MessageLoop::QuitWhenIdleClosure());
+    base::ThreadTaskRunnerHandle::Get()->PostTask(
+        FROM_HERE, base::MessageLoop::QuitWhenIdleClosure());

[msw, 2015/06/10 00:12:58]

Is this still correct? Maybe update the QuitLoop() function name?

[Sami, 2015/06/10 12:35:34]

Yes, this is still exiting the message loop for the current thread. Only the way
the quit closure is posted changes.

   }
 
  private:
   DISALLOW_COPY_AND_ASSIGN(WindowSizerContextMenuTest);
 };
 
 void OpenBrowserUsingContextMenuOnRootWindow(aura::Window* root_window) {
   gfx::Point chrome_icon =
       GetChromeIconBoundsForRootWindow(root_window).CenterPoint();
   gfx::Point release_point = chrome_icon;
@@ skipping 34 matching lines @@
 
   // Next new browser must be created on 1st display.
   ASSERT_EQ(2u, browser_list->size());
   EXPECT_EQ(root_windows[0],
             browser_list->get(1)->window()->GetNativeWindow()->GetRootWindow());
   EXPECT_EQ(root_windows[0], ash::Shell::GetTargetRootWindow());
 
   // Balanced with the chrome::IncrementKeepAliveCount above.
   chrome::DecrementKeepAliveCount();
 }