Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5470)

Unified Diff: chrome/browser/ui/views/toolbar/chevron_menu_button.cc

Issue 1160073004: chrome/browser/ui: Remove use of MessageLoopProxy and deprecated MessageLoop APIs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Check for task runner instead of current message loop. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/toolbar/chevron_menu_button.cc
diff --git a/chrome/browser/ui/views/toolbar/chevron_menu_button.cc b/chrome/browser/ui/views/toolbar/chevron_menu_button.cc
index 1083cb47e81cf1d927c380ce3d66afdbf3cde140..5fc97b4faa16340aa4dc19e11ef6cc1f68115dc8 100644
--- a/chrome/browser/ui/views/toolbar/chevron_menu_button.cc
+++ b/chrome/browser/ui/views/toolbar/chevron_menu_button.cc
@@ -4,9 +4,11 @@
#include "chrome/browser/ui/views/toolbar/chevron_menu_button.h"
+#include "base/location.h"
#include "base/memory/scoped_vector.h"
-#include "base/message_loop/message_loop.h"
+#include "base/single_thread_task_runner.h"
#include "base/strings/utf_string_conversions.h"
+#include "base/thread_task_runner_handle.h"
#include "chrome/browser/extensions/extension_action.h"
#include "chrome/browser/extensions/extension_action_icon_factory.h"
#include "chrome/browser/extensions/extension_context_menu_model.h"
@@ -197,10 +199,9 @@ void ChevronMenuButton::MenuController::RunMenu(views::Widget* window) {
if (!for_drop_) {
// Give the context menu (if any) a chance to execute the user-selected
// command.
- base::MessageLoop::current()->PostTask(
- FROM_HERE,
- base::Bind(&ChevronMenuButton::MenuDone,
- owner_->weak_factory_.GetWeakPtr()));
+ base::ThreadTaskRunnerHandle::Get()->PostTask(
+ FROM_HERE, base::Bind(&ChevronMenuButton::MenuDone,
+ owner_->weak_factory_.GetWeakPtr()));
}
}
@@ -395,11 +396,9 @@ bool ChevronMenuButton::CanDrop(const OSExchangeData& data) {
void ChevronMenuButton::OnDragEntered(const ui::DropTargetEvent& event) {
DCHECK(!weak_factory_.HasWeakPtrs());
if (!menu_controller_) {
- base::MessageLoop::current()->PostDelayedTask(
- FROM_HERE,
- base::Bind(&ChevronMenuButton::ShowOverflowMenu,
- weak_factory_.GetWeakPtr(),
- true),
+ base::ThreadTaskRunnerHandle::Get()->PostDelayedTask(
+ FROM_HERE, base::Bind(&ChevronMenuButton::ShowOverflowMenu,
+ weak_factory_.GetWeakPtr(), true),
base::TimeDelta::FromMilliseconds(views::GetMenuShowDelay()));
}
}

Powered by Google App Engine
This is Rietveld 408576698