chrome/browser/ui/views/status_icons/status_tray_win.cc - Issue 1160073004: chrome/browser/ui: Remove use of MessageLoopProxy and deprecated MessageLoop APIs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/status_icons/status_tray_win.cc

Issue 1160073004: chrome/browser/ui: Remove use of MessageLoopProxy and deprecated MessageLoop APIs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Check for task runner instead of current message loop. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/views/status_bubble_views.cc ('K') | « chrome/browser/ui/views/status_bubble_views.cc ('k') | chrome/browser/ui/views/toolbar/chevron_menu_button.cc » ('j') | chrome/browser/ui/webui/chromeos/login/l10n_util_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/status_icons/status_tray_win.cc

diff --git a/chrome/browser/ui/views/status_icons/status_tray_win.cc b/chrome/browser/ui/views/status_icons/status_tray_win.cc

index 099fb6c20f284ac3dd85d2afc58c69c50f20b759..5237b2aa89bbf24feaefe172a70ee986b368dc40 100644

--- a/chrome/browser/ui/views/status_icons/status_tray_win.cc

+++ b/chrome/browser/ui/views/status_icons/status_tray_win.cc

@@ -76,12 +76,11 @@ class StatusTrayStateChangerProxyImpl : public StatusTrayStateChangerProxy,

worker_thread_.Start();

++pending_requests_;

- worker_thread_.message_loop_proxy()->PostTaskAndReply(

+ worker_thread_.task_runner()->PostTaskAndReply(

msw 2015/06/10 00:12:57 Should this file include location.h and single_thr

Sami 2015/06/10 12:35:34 Yes, well spotted, thanks. The automated rewriting

FROM_HERE,

base::Bind(

&StatusTrayStateChangerProxyImpl::EnqueueChangeOnWorkerThread,

- icon_id,

- window),

+ icon_id, window),

base::Bind(&StatusTrayStateChangerProxyImpl::ChangeDone,

weak_factory_.GetWeakPtr()));

}