chrome/browser/ui/unload_controller.cc - Issue 1160073004: chrome/browser/ui: Remove use of MessageLoopProxy and deprecated MessageLoop APIs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/unload_controller.cc

Issue 1160073004: chrome/browser/ui: Remove use of MessageLoopProxy and deprecated MessageLoop APIs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Check for task runner instead of current message loop. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/tab_modal_confirm_dialog_browsertest.cc ('K') | « chrome/browser/ui/toolbar/toolbar_actions_bar.cc ('k') | chrome/browser/ui/views/ash/tab_scrubber_browsertest.cc » ('j') | chrome/browser/ui/views/ash/tab_scrubber_browsertest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/unload_controller.cc

diff --git a/chrome/browser/ui/unload_controller.cc b/chrome/browser/ui/unload_controller.cc

index 96a39297e62a150ceea90df9acf64ea47091e696..4dfcf3633a123951e42894430c0a9e06f2bef200 100644

--- a/chrome/browser/ui/unload_controller.cc

+++ b/chrome/browser/ui/unload_controller.cc

@@ -4,7 +4,9 @@

#include "chrome/browser/ui/unload_controller.h"

-#include "base/message_loop/message_loop.h"

+#include "base/location.h"

+#include "base/single_thread_task_runner.h"

+#include "base/thread_task_runner_handle.h"

#include "chrome/browser/chrome_notification_types.h"

#include "chrome/browser/devtools/devtools_window.h"

#include "chrome/browser/ui/browser.h"

@@ -356,10 +358,9 @@ void UnloadController::ClearUnloadState(content::WebContents* web_contents,

if (process_now) {

ProcessPendingTabs();

} else {

- base::MessageLoop::current()->PostTask(

- FROM_HERE,

- base::Bind(&UnloadController::ProcessPendingTabs,

- weak_factory_.GetWeakPtr()));

+ base::ThreadTaskRunnerHandle::Get()->PostTask(

+ FROM_HERE, base::Bind(&UnloadController::ProcessPendingTabs,

+ weak_factory_.GetWeakPtr()));

}