chrome/browser/ui: Remove use of MessageLoopProxy and deprecated MessageLoop APIs

chrome/browser/ui/tab_modal_confirm_dialog_browsertest.cc

Index: chrome/browser/ui/tab_modal_confirm_dialog_browsertest.cc
diff --git a/chrome/browser/ui/tab_modal_confirm_dialog_browsertest.cc b/chrome/browser/ui/tab_modal_confirm_dialog_browsertest.cc
index 0eb025b0f9fd85abfd7265f205b1010b5ff9598e..2ce91ba3e44851cf7fcf1214da0941ec27ec4820 100644
--- a/chrome/browser/ui/tab_modal_confirm_dialog_browsertest.cc
+++ b/chrome/browser/ui/tab_modal_confirm_dialog_browsertest.cc
@@ -5,7 +5,10 @@
 #include "chrome/browser/ui/tab_modal_confirm_dialog_browsertest.h"
 
 #include "base/bind.h"
+#include "base/location.h"
+#include "base/single_thread_task_runner.h"
 #include "base/strings/utf_string_conversions.h"
+#include "base/thread_task_runner_handle.h"
 #include "chrome/browser/lifetime/application_lifetime.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_dialogs.h"
@@ -130,8 +133,8 @@ IN_PROC_BROWSER_TEST_F(TabModalConfirmDialogTest, Navigate) {
 }
 
 IN_PROC_BROWSER_TEST_F(TabModalConfirmDialogTest, Quit) {
-  base::MessageLoopForUI::current()->PostTask(FROM_HERE,
-                                              base::Bind(&chrome::AttemptExit));
+  base::ThreadTaskRunnerHandle::Get()->PostTask(
+      FROM_HERE, base::Bind(&chrome::AttemptExit));
   content::RunMessageLoop();

[msw, 2015/06/10 00:12:57]

Is this still correct?

[Sami, 2015/06/10 12:35:33]

Yes, it is posting a task to the same message loop as before
(ThreadTaskRunnerHandle always points to the current thread's message loop).

The only difference is that we're no longer asserting the type of the message
loop (UI), but from a cursory look it doesn't feel like this test should be
checking that since it's relying on the normal content test harness to set
everything up.

[msw, 2015/06/10 19:34:00]

If feels odd to post a task to base::ThreadTaskRunnerHandle::Get() and then call
content::RunMessageLoop()... Is there a way to run that SingleThreadTaskRunner
directly or with more consistent terminology? ie. it seems silly that you can't
call base::ThreadTaskRunnerHandle::Get()->Run().

   EXPECT_EQ(0, accepted_count_);
   EXPECT_EQ(0, canceled_count_);