chrome/browser/ui: Remove use of MessageLoopProxy and deprecated MessageLoop APIs

chrome/browser/ui/tab_modal_confirm_dialog_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/tab_modal_confirm_dialog_browsertest.h"
 
 #include "base/bind.h"
+#include "base/location.h"
+#include "base/single_thread_task_runner.h"
 #include "base/strings/utf_string_conversions.h"
+#include "base/thread_task_runner_handle.h"
 #include "chrome/browser/lifetime/application_lifetime.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_dialogs.h"
 #include "chrome/browser/ui/tabs/tab_strip_model.h"
 #include "content/public/browser/page_navigator.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/test/test_utils.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "ui/base/window_open_disposition.h"
 
@@ skipping 104 matching lines @@
                                 ui::PAGE_TRANSITION_LINK,
                                 false);
   browser()->tab_strip_model()->GetActiveWebContents()->OpenURL(params);
 
   EXPECT_EQ(0, accepted_count_);
   EXPECT_EQ(0, canceled_count_);
   EXPECT_EQ(1, closed_count_);
 }
 
 IN_PROC_BROWSER_TEST_F(TabModalConfirmDialogTest, Quit) {
-  base::MessageLoopForUI::current()->PostTask(FROM_HERE,
-                                              base::Bind(&chrome::AttemptExit));
+  base::ThreadTaskRunnerHandle::Get()->PostTask(
+      FROM_HERE, base::Bind(&chrome::AttemptExit));
   content::RunMessageLoop();

[msw, 2015/06/10 00:12:57]

Is this still correct?

[Sami, 2015/06/10 12:35:33]

Yes, it is posting a task to the same message loop as before
(ThreadTaskRunnerHandle always points to the current thread's message loop).

The only difference is that we're no longer asserting the type of the message
loop (UI), but from a cursory look it doesn't feel like this test should be
checking that since it's relying on the normal content test harness to set
everything up.

[msw, 2015/06/10 19:34:00]

If feels odd to post a task to base::ThreadTaskRunnerHandle::Get() and then call
content::RunMessageLoop()... Is there a way to run that SingleThreadTaskRunner
directly or with more consistent terminology? ie. it seems silly that you can't
call base::ThreadTaskRunnerHandle::Get()->Run().

   EXPECT_EQ(0, accepted_count_);
   EXPECT_EQ(0, canceled_count_);
   EXPECT_EQ(1, closed_count_);
 }