Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(694)

Issue 115993006: Revert of Remove installation of Chrome Frame. (Closed)

Created:
6 years, 12 months ago by Nikita (slow)
Modified:
6 years, 12 months ago
CC:
chromium-reviews, grt+watch_chromium.org
Visibility:
Public.

Description

Revert of https://codereview.chromium.org/117433002/ Reason for revert: Reverting this change just to confirm that sizes change is triggered by it. TBR=robertshield@chromium.org,gab@chromium.org,grt@chromium.org NOTREECHECKS=true NOTRY=true BUG=316496

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+476 lines, -87 lines) Patch
M chrome/app/chromium_strings.grd View 2 chunks +9 lines, -0 lines 0 comments Download
M chrome/app/google_chrome_strings.grd View 2 chunks +9 lines, -0 lines 0 comments Download
M chrome/chrome_installer.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
A chrome/installer/setup/cf_migration.h View 1 chunk +45 lines, -0 lines 0 comments Download
A chrome/installer/setup/cf_migration.cc View 1 chunk +131 lines, -0 lines 0 comments Download
M chrome/installer/setup/install.cc View 1 chunk +9 lines, -7 lines 0 comments Download
M chrome/installer/setup/install_worker.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/installer/setup/install_worker.cc View 7 chunks +40 lines, -3 lines 0 comments Download
M chrome/installer/setup/install_worker_unittest.cc View 1 chunk +13 lines, -0 lines 0 comments Download
M chrome/installer/setup/setup_main.cc View 13 chunks +85 lines, -6 lines 0 comments Download
M chrome/installer/setup/setup_util.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/installer/setup/setup_util.cc View 1 chunk +0 lines, -20 lines 0 comments Download
M chrome/installer/setup/setup_util_unittest.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M chrome/installer/util/browser_distribution.cc View 1 chunk +6 lines, -1 line 0 comments Download
M chrome/installer/util/installer_state.cc View 4 chunks +37 lines, -17 lines 0 comments Download
M chrome/installer/util/installer_state_unittest.cc View 3 chunks +17 lines, -9 lines 0 comments Download
M chrome/installer/util/logging_installer.cc View 1 chunk +11 lines, -7 lines 0 comments Download
M chrome/installer/util/master_preferences.h View 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/installer/util/master_preferences.cc View 7 chunks +15 lines, -2 lines 0 comments Download
M chrome/installer/util/master_preferences_constants.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/installer/util/master_preferences_constants.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/installer/util/master_preferences_unittest.cc View 1 chunk +26 lines, -1 line 0 comments Download
M chrome/installer/util/prebuild/create_string_rc.py View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/installer/util/util_constants.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/installer/util/util_constants.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Nikita (slow)
Created Revert of Remove installation of Chrome Frame.
6 years, 12 months ago (2013-12-24 13:22:54 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nkostylev@chromium.org/115993006/1
6 years, 12 months ago (2013-12-24 13:23:05 UTC) #2
commit-bot: I haz the power
Failed to apply patch for chrome/installer/setup/install.cc: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 12 months ago (2013-12-24 13:23:16 UTC) #3
Nikita (slow)
6 years, 12 months ago (2013-12-24 13:26:16 UTC) #4
Please ignore this test revert.
It is not applying cleanly so I'll just abandon it.

Powered by Google App Engine
This is Rietveld 408576698