Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Side by Side Diff: chrome/installer/setup/install.cc

Issue 115993006: Revert of Remove installation of Chrome Frame. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/installer/setup/cf_migration.cc ('k') | chrome/installer/setup/install_worker.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/installer/setup/install.h" 5 #include "chrome/installer/setup/install.h"
6 6
7 #include <windows.h> 7 #include <windows.h>
8 #include <shlobj.h> 8 #include <shlobj.h>
9 #include <time.h> 9 #include <time.h>
10 10
(...skipping 488 matching lines...) Expand 10 before | Expand all | Expand 10 after
499 InstallStatus InstallOrUpdateProduct( 499 InstallStatus InstallOrUpdateProduct(
500 const InstallationState& original_state, 500 const InstallationState& original_state,
501 const InstallerState& installer_state, 501 const InstallerState& installer_state,
502 const base::FilePath& setup_path, 502 const base::FilePath& setup_path,
503 const base::FilePath& archive_path, 503 const base::FilePath& archive_path,
504 const base::FilePath& install_temp_path, 504 const base::FilePath& install_temp_path,
505 const base::FilePath& src_path, 505 const base::FilePath& src_path,
506 const base::FilePath& prefs_path, 506 const base::FilePath& prefs_path,
507 const MasterPreferences& prefs, 507 const MasterPreferences& prefs,
508 const Version& new_version) { 508 const Version& new_version) {
509 DCHECK(!installer_state.products().empty());
510
511 // TODO(robertshield): Removing the pending on-reboot moves should be done 509 // TODO(robertshield): Removing the pending on-reboot moves should be done
512 // elsewhere. 510 // elsewhere.
513 // Remove any scheduled MOVEFILE_DELAY_UNTIL_REBOOT entries in the target of 511 // TODO(erikwright): Understand why this is Chrome Frame only and whether
514 // this installation. These may have been added during a previous uninstall of 512 // it also applies to App Host. Shouldn't it apply to any multi-install too?
515 // the same version. 513 const Products& products = installer_state.products();
516 LOG_IF(ERROR, !RemoveFromMovesPendingReboot(installer_state.target_path())) 514 DCHECK(products.size());
517 << "Error accessing pending moves value."; 515 if (installer_state.FindProduct(BrowserDistribution::CHROME_FRAME)) {
516 // Make sure that we don't end up deleting installed files on next reboot.
517 if (!RemoveFromMovesPendingReboot(installer_state.target_path()))
518 LOG(ERROR) << "Error accessing pending moves value.";
519 }
518 520
519 // Create VisualElementManifest.xml in |src_path| (if required) so that it 521 // Create VisualElementManifest.xml in |src_path| (if required) so that it
520 // looks as if it had been extracted from the archive when calling 522 // looks as if it had been extracted from the archive when calling
521 // InstallNewVersion() below. 523 // InstallNewVersion() below.
522 installer_state.UpdateStage(installer::CREATING_VISUAL_MANIFEST); 524 installer_state.UpdateStage(installer::CREATING_VISUAL_MANIFEST);
523 CreateVisualElementsManifest(src_path, new_version); 525 CreateVisualElementsManifest(src_path, new_version);
524 526
525 scoped_ptr<Version> existing_version; 527 scoped_ptr<Version> existing_version;
526 InstallStatus result = InstallNewVersion(original_state, installer_state, 528 InstallStatus result = InstallNewVersion(original_state, installer_state,
527 setup_path, archive_path, src_path, install_temp_path, new_version, 529 setup_path, archive_path, src_path, install_temp_path, new_version,
(...skipping 172 matching lines...) Expand 10 before | Expand all | Expand 10 after
700 if (app_host_path.empty()) 702 if (app_host_path.empty())
701 return false; 703 return false;
702 704
703 CommandLine cmd(app_host_path); 705 CommandLine cmd(app_host_path);
704 cmd.AppendSwitchASCII(::switches::kInstallFromWebstore, app_code); 706 cmd.AppendSwitchASCII(::switches::kInstallFromWebstore, app_code);
705 VLOG(1) << "App install command: " << cmd.GetCommandLineString(); 707 VLOG(1) << "App install command: " << cmd.GetCommandLineString();
706 return base::LaunchProcess(cmd, base::LaunchOptions(), NULL); 708 return base::LaunchProcess(cmd, base::LaunchOptions(), NULL);
707 } 709 }
708 710
709 } // namespace installer 711 } // namespace installer
OLDNEW
« no previous file with comments | « chrome/installer/setup/cf_migration.cc ('k') | chrome/installer/setup/install_worker.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698