Remove WebMediaPlayerImpl::GetClient() because it's useless.

Remove WebMediaPlayerImpl::GetClient() because it's useless.

It was added in r20038 when WebMediaPlayerImpl was made refcounted (!).

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=242111

[scherkus (not reviewing), 2013-12-19 20:40:09]

happy holidays

[Ami GONE FROM CHROMIUM, 2013-12-19 21:00:49]

LGTM

https://codereview.chromium.org/115993004/diff/20001/content/renderer/media/w...
File content/renderer/media/webmediaplayer_impl.cc (left):

https://codereview.chromium.org/115993004/diff/20001/content/renderer/media/w...
content/renderer/media/webmediaplayer_impl.cc:1233:
DCHECK(main_loop_->BelongsToCurrentThread());
This is the only bit I (slightly) regret losing with this CL: previously this
enforced that only the main thread accessed client_ but now all callers need to
know.

Clearly the time has come for SingleThreadedUnownedPointer!

(you could use a WeakPtr for this but that probably cross the
crazy-event-horizon; also you could sprinkle WebMediaPlayerClientImpl's public
methods with ASSERT(isOnMainThread())'s, and that might actually make sense, I'm
not sure).

[scherkus (not reviewing), 2013-12-19 21:14:09]

https://codereview.chromium.org/115993004/diff/20001/content/renderer/media/w...
File content/renderer/media/webmediaplayer_impl.cc (left):

https://codereview.chromium.org/115993004/diff/20001/content/renderer/media/w...
content/renderer/media/webmediaplayer_impl.cc:1233:
DCHECK(main_loop_->BelongsToCurrentThread());
On 2013/12/19 21:00:50, Ami Fischman (OOO Dec23-Jan5) wrote:
> This is the only bit I (slightly) regret losing with this CL: previously this
> enforced that only the main thread accessed client_ but now all callers need
to
> know.

that assumes future coders realize they should be using GetClient() versus
client_ :P

> Clearly the time has come for SingleThreadedUnownedPointer!
> 
> (you could use a WeakPtr for this but that probably cross the
> crazy-event-horizon; also you could sprinkle WebMediaPlayerClientImpl's public
> methods with ASSERT(isOnMainThread())'s, and that might actually make sense,
I'm
> not sure).

if anything I'd do the WebMediaPlayerClientImpl change ... but I feel it's
getting overly paranoid considering it's blink code at that point which mostly
runs on the main thread by convention

[commit-bot: I haz the power, 2013-12-19 21:17:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/scherkus@chromium.org/115993004/20001

[commit-bot: I haz the power, 2013-12-20 02:40:50]

Retried try job too often on linux_aura for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura...

[commit-bot: I haz the power, 2013-12-20 02:46:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/scherkus@chromium.org/115993004/20001

[commit-bot: I haz the power, 2013-12-20 10:30:32]

Retried try job too often on linux_aura for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura...

[commit-bot: I haz the power, 2013-12-20 15:20:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/scherkus@chromium.org/115993004/20001

[commit-bot: I haz the power, 2013-12-20 17:04:37]

Change committed as 242111