Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(930)

Side by Side Diff: content/renderer/media/webmediaplayer_impl.h

Issue 115993004: Remove WebMediaPlayerImpl::GetClient() because it's useless. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Delegate calls from WebCore::MediaPlayerPrivate to Chrome's video player. 5 // Delegate calls from WebCore::MediaPlayerPrivate to Chrome's video player.
6 // It contains Pipeline which is the actual media player pipeline, it glues 6 // It contains Pipeline which is the actual media player pipeline, it glues
7 // the media player pipeline, data source, audio renderer and renderer. 7 // the media player pipeline, data source, audio renderer and renderer.
8 // Pipeline would creates multiple threads and access some public methods 8 // Pipeline would creates multiple threads and access some public methods
9 // of this class, so we need to be extra careful about concurrent access of 9 // of this class, so we need to be extra careful about concurrent access of
10 // methods and members. 10 // methods and members.
(...skipping 205 matching lines...) Expand 10 before | Expand all | Expand 10 after
216 void StartPipeline(); 216 void StartPipeline();
217 217
218 // Helpers that set the network/ready state and notifies the client if 218 // Helpers that set the network/ready state and notifies the client if
219 // they've changed. 219 // they've changed.
220 void SetNetworkState(blink::WebMediaPlayer::NetworkState state); 220 void SetNetworkState(blink::WebMediaPlayer::NetworkState state);
221 void SetReadyState(blink::WebMediaPlayer::ReadyState state); 221 void SetReadyState(blink::WebMediaPlayer::ReadyState state);
222 222
223 // Destroy resources held. 223 // Destroy resources held.
224 void Destroy(); 224 void Destroy();
225 225
226 // Getter method to |client_|.
227 blink::WebMediaPlayerClient* GetClient();
228
229 // Lets V8 know that player uses extra resources not managed by V8. 226 // Lets V8 know that player uses extra resources not managed by V8.
230 void IncrementExternallyAllocatedMemory(); 227 void IncrementExternallyAllocatedMemory();
231 228
232 // Actually do the work for generateKeyRequest/addKey so they can easily 229 // Actually do the work for generateKeyRequest/addKey so they can easily
233 // report results to UMA. 230 // report results to UMA.
234 MediaKeyException GenerateKeyRequestInternal( 231 MediaKeyException GenerateKeyRequestInternal(
235 const blink::WebString& key_system, 232 const blink::WebString& key_system,
236 const unsigned char* init_data, 233 const unsigned char* init_data,
237 unsigned init_data_length); 234 unsigned init_data_length);
238 MediaKeyException AddKeyInternal(const blink::WebString& key_system, 235 MediaKeyException AddKeyInternal(const blink::WebString& key_system,
(...skipping 133 matching lines...) Expand 10 before | Expand all | Expand 10 after
372 369
373 // Text track objects get a unique index value when they're created. 370 // Text track objects get a unique index value when they're created.
374 int text_track_index_; 371 int text_track_index_;
375 372
376 DISALLOW_COPY_AND_ASSIGN(WebMediaPlayerImpl); 373 DISALLOW_COPY_AND_ASSIGN(WebMediaPlayerImpl);
377 }; 374 };
378 375
379 } // namespace content 376 } // namespace content
380 377
381 #endif // CONTENT_RENDERER_MEDIA_WEBMEDIAPLAYER_IMPL_H_ 378 #endif // CONTENT_RENDERER_MEDIA_WEBMEDIAPLAYER_IMPL_H_
OLDNEW
« no previous file with comments | « no previous file | content/renderer/media/webmediaplayer_impl.cc » ('j') | content/renderer/media/webmediaplayer_impl.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698