components/metrics/metrics_service.cc - Issue 1159883003: Substituting pattern ScopedVector push_back(ptr.release()) with push_back(ptr.Pass()) in components…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/metrics/metrics_service.cc

Issue 1159883003: Substituting pattern ScopedVector push_back(ptr.release()) with push_back(ptr.Pass()) in components… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/metrics/metrics_service.cc

diff --git a/components/metrics/metrics_service.cc b/components/metrics/metrics_service.cc

index fe5348940b60d0be62aeb8088a6542d5fe6cdbdb..598d9daa7f813613f113d61d43595d1e43575fa7 100644

--- a/components/metrics/metrics_service.cc

+++ b/components/metrics/metrics_service.cc

@@ -1045,7 +1045,7 @@ void MetricsService::RegisterSyntheticFieldTrial(

void MetricsService::RegisterMetricsProvider(

scoped_ptr<MetricsProvider> provider) {

DCHECK_EQ(INITIALIZED, state_);

- metrics_providers_.push_back(provider.release());

+ metrics_providers_.push_back(provider.Pass());

}

void MetricsService::CheckForClonedInstall(

« no previous file with comments | « components/metrics/daily_event.cc ('k') | components/metrics/serialization/serialization_utils.cc » ('j') | no next file with comments »