components/metrics/daily_event.cc - Issue 1159883003: Substituting pattern ScopedVector push_back(ptr.release()) with push_back(ptr.Pass()) in components…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/metrics/daily_event.cc

Issue 1159883003: Substituting pattern ScopedVector push_back(ptr.release()) with push_back(ptr.Pass()) in components… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/metrics/daily_event.cc

diff --git a/components/metrics/daily_event.cc b/components/metrics/daily_event.cc

index b9bc62a4e13d08399a66f925f7106e9a152372e5..86899c746dcf23a0cccf2826c5a262fedf246561 100644

--- a/components/metrics/daily_event.cc

+++ b/components/metrics/daily_event.cc

@@ -58,7 +58,7 @@ void DailyEvent::RegisterPref(PrefRegistrySimple* registry,

void DailyEvent::AddObserver(scoped_ptr<DailyEvent::Observer> observer) {

DVLOG(2) << "DailyEvent observer added.";

DCHECK(last_fired_.is_null());

- observers_.push_back(observer.release());

+ observers_.push_back(observer.Pass());

}

void DailyEvent::CheckInterval() {

« no previous file with comments | « no previous file | components/metrics/metrics_service.cc » ('j') | no next file with comments »