Issue 1159883003: Substituting pattern ScopedVector push_back(ptr.release()) with push_back(ptr.Pass()) in components…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1159883003: Substituting pattern ScopedVector push_back(ptr.release()) with push_back(ptr.Pass()) in components… (Closed)

Created:
5 years, 6 months ago by d.samantaray

Modified:
5 years, 6 months ago

Reviewers:
Ilya Sherman

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Substituting pattern ScopedVector push_back(ptr.release()) with push_back(ptr.Pass()) in components/metrics BUG=457697 Committed: https://crrev.com/d7012f5492e1513f28cdb4fbb814f7e71a355dde Cr-Commit-Position: refs/heads/master@{#331628}

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -3 lines)			Patch
M	components/metrics/daily_event.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	components/metrics/metrics_service.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	components/metrics/serialization/serialization_utils.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 7 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1159883003/1

5 years, 6 months ago (2015-05-27 18:20:20 UTC) #5

commit-bot: I haz the power

5 years, 6 months ago (2015-05-27 19:54:45 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/d7012f5492e1513f28cdb4fbb814f7e71a355dde
Cr-Commit-Position: refs/heads/master@{#331628}