Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1159833003: New SELECT Popup: Recalc style when a web font is loaded (Closed)

Created:
5 years, 6 months ago by keishi
Modified:
5 years, 6 months ago
CC:
blink-reviews, blink-reviews-style_chromium.org, blink-reviews-css, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, apavlov+blink_chromium.org, darktears, rwlbuis
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

New SELECT Popup: Recalc style when a web font is loaded PopupMenuCSSFontSelector should relay the invalidation callback from m_ownerFontSelector so the style willbe recalculated when a font loads on the owner page. BUG=481515 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197039

Patch Set 1 #

Total comments: 9

Patch Set 2 : Fixed #

Total comments: 4

Patch Set 3 : fixed #

Patch Set 4 : rebased #

Patch Set 5 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -9 lines) Patch
M LayoutTests/TestExpectations View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/fast/forms/resources/picker-common.js View 1 chunk +5 lines, -1 line 0 comments Download
A LayoutTests/http/tests/webfont/popup-menu-load-webfont-after-open.html View 1 4 1 chunk +38 lines, -0 lines 0 comments Download
M Source/core/css/CSSFontSelector.h View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/dom/StyleEngine.cpp View 1 2 3 1 chunk +6 lines, -0 lines 0 comments Download
M Source/web/PopupMenuImpl.cpp View 1 2 3 2 chunks +27 lines, -6 lines 0 comments Download
M Tools/Scripts/webkitpy/layout_tests/servers/apache_http.py View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 24 (9 generated)
keishi
PTAL
5 years, 6 months ago (2015-05-29 04:39:55 UTC) #2
tkent
+ksakamoto
5 years, 6 months ago (2015-05-29 04:48:50 UTC) #4
tkent
https://codereview.chromium.org/1159833003/diff/1/LayoutTests/http/tests/webfont/popup-menu-load-webfont-after-open.html File LayoutTests/http/tests/webfont/popup-menu-load-webfont-after-open.html (right): https://codereview.chromium.org/1159833003/diff/1/LayoutTests/http/tests/webfont/popup-menu-load-webfont-after-open.html#newcode9 LayoutTests/http/tests/webfont/popup-menu-load-webfont-after-open.html:9: @font-face { Indentation in this <style> is inconsistent. https://codereview.chromium.org/1159833003/diff/1/LayoutTests/http/tests/webfont/popup-menu-load-webfont-after-open.html#newcode22 ...
5 years, 6 months ago (2015-05-29 05:41:03 UTC) #5
Kunihiko Sakamoto
https://codereview.chromium.org/1159833003/diff/1/Source/web/PopupMenuImpl.cpp File Source/web/PopupMenuImpl.cpp (right): https://codereview.chromium.org/1159833003/diff/1/Source/web/PopupMenuImpl.cpp#newcode58 Source/web/PopupMenuImpl.cpp:58: { Don't we need to unregister from m_ownerFontSelector?
5 years, 6 months ago (2015-05-29 05:57:35 UTC) #6
keishi
https://codereview.chromium.org/1159833003/diff/1/LayoutTests/http/tests/webfont/popup-menu-load-webfont-after-open.html File LayoutTests/http/tests/webfont/popup-menu-load-webfont-after-open.html (right): https://codereview.chromium.org/1159833003/diff/1/LayoutTests/http/tests/webfont/popup-menu-load-webfont-after-open.html#newcode9 LayoutTests/http/tests/webfont/popup-menu-load-webfont-after-open.html:9: @font-face { On 2015/05/29 05:41:02, tkent wrote: > Indentation ...
5 years, 6 months ago (2015-05-29 07:30:51 UTC) #7
Kunihiko Sakamoto
https://codereview.chromium.org/1159833003/diff/20001/LayoutTests/TestExpectations File LayoutTests/TestExpectations (right): https://codereview.chromium.org/1159833003/diff/20001/LayoutTests/TestExpectations#newcode29 LayoutTests/TestExpectations:29: #crbug.com/481515 http/tests/webfont/popup-menu-load-webfont-after-open.html [ NeedsRebaseline ] Commented out intentionally? https://codereview.chromium.org/1159833003/diff/20001/Source/web/PopupMenuImpl.cpp ...
5 years, 6 months ago (2015-05-29 07:40:06 UTC) #8
keishi
https://codereview.chromium.org/1159833003/diff/20001/LayoutTests/TestExpectations File LayoutTests/TestExpectations (right): https://codereview.chromium.org/1159833003/diff/20001/LayoutTests/TestExpectations#newcode29 LayoutTests/TestExpectations:29: #crbug.com/481515 http/tests/webfont/popup-menu-load-webfont-after-open.html [ NeedsRebaseline ] On 2015/05/29 07:40:06, Kunihiko ...
5 years, 6 months ago (2015-06-02 05:33:00 UTC) #9
tkent
lgtm
5 years, 6 months ago (2015-06-02 05:37:05 UTC) #10
Kunihiko Sakamoto
lgtm
5 years, 6 months ago (2015-06-02 05:41:58 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1159833003/40001
5 years, 6 months ago (2015-06-03 05:18:04 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_compile_dbg on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/mac_blink_compile_dbg/builds/46293)
5 years, 6 months ago (2015-06-03 05:21:52 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1159833003/60001
5 years, 6 months ago (2015-06-12 13:47:02 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/35270)
5 years, 6 months ago (2015-06-12 13:53:34 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1159833003/80001
5 years, 6 months ago (2015-06-12 14:01:39 UTC) #23
commit-bot: I haz the power
5 years, 6 months ago (2015-06-12 15:07:14 UTC) #24
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197039

Powered by Google App Engine
This is Rietveld 408576698