Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(433)

Unified Diff: Source/web/tests/ProgrammaticScrollTest.cpp

Issue 1159723003: Don't reuse HistoryItems for multiple navigations (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Address comments Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/web/tests/ProgrammaticScrollTest.cpp
diff --git a/Source/web/tests/ProgrammaticScrollTest.cpp b/Source/web/tests/ProgrammaticScrollTest.cpp
index 08320f4dbb7922cce358b94291ddb597f9796d26..81c16af4f5ab63b462778ec76fe26779bfbefa05 100644
--- a/Source/web/tests/ProgrammaticScrollTest.cpp
+++ b/Source/web/tests/ProgrammaticScrollTest.cpp
@@ -92,10 +92,10 @@ TEST_F(ProgrammaticScrollTest, RestoreScrollPositionAndViewStateWithoutScale)
webViewImpl->setPageScaleFactor(3.0f);
webViewImpl->setMainFrameScrollOffset(WebPoint(0, 500));
frame->view()->setWasScrolledByUser(false);
- frame->loader().currentItem()->setPageScaleFactor(0);
+ frame->loader().currentItem()->setPageScaleFactor(1.0f);
frame->loader().currentItem()->setScrollPoint(WebPoint(0, 400));
- // FrameLoader::restoreScrollPositionAndViewState flows differently if scale is zero.
+ // FrameLoader::restoreScrollPositionAndViewState flows differently if scale is 1.
frame->loader().restoreScrollPositionAndViewState();
// Expect that only the scroll position was restored.

Powered by Google App Engine
This is Rietveld 408576698