Source/web/WebViewImpl.cpp - Issue 1159723003: Don't reuse HistoryItems for multiple navigations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebViewImpl.cpp

Issue 1159723003: Don't reuse HistoryItems for multiple navigations (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Address comments Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/web/WebViewImpl.cpp

diff --git a/Source/web/WebViewImpl.cpp b/Source/web/WebViewImpl.cpp

index 9f36a8070a6b2992fc961c234a97530078f747b2..8146011ff2dbd0a6ecf168c873da6eca94305670 100644

--- a/Source/web/WebViewImpl.cpp

+++ b/Source/web/WebViewImpl.cpp

@@ -3408,10 +3408,6 @@ void WebViewImpl::resetScrollAndScaleState()

if (!page()->mainFrame()->isLocalFrame())

return;

- // Clear out the values for the current history item. This will prevent the history item from clobbering the

- // value determined during page scale initialization, which may be less than 1.

- page()->deprecatedLocalMainFrame()->loader().clearScrollPositionAndViewState();

pageScaleConstraintsSet().setNeedsReset(true);

// Clobber saved scales and scroll offsets.