Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1159623003: Add skeleton UI for sync page. (Closed)

Created:
5 years, 6 months ago by Kyle Horimoto
Modified:
5 years, 6 months ago
Reviewers:
James Hawkins
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add skeleton UI for sync page. This CL creates the new page, adds its strings, and brings in new Polymer dependencies on the paper-radio-* elements. This CL does not add functionality or proper styling to the page. This will be done in follow-up CLs. R=jhawkins@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/79f377603917b9f5c836158b27257a533b6dde35

Patch Set 1 #

Patch Set 2 : Some UI code. #

Patch Set 3 : Skeleton UI finished. No functionality. #

Patch Set 4 : Barebones UI. #

Patch Set 5 : Fix some lint issues. #

Total comments: 8

Patch Set 6 : jhawkins comments. #

Total comments: 2

Patch Set 7 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+273 lines, -17 lines) Patch
M chrome/app/chromium_strings.grd View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/app/google_chrome_strings.grd View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
A chrome/app/settings_chromium_strings.grdp View 1 2 3 4 5 1 chunk +8 lines, -0 lines 0 comments Download
A chrome/app/settings_google_chrome_strings.grdp View 1 2 3 4 5 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/app/settings_strings.grdp View 1 2 3 4 5 6 2 chunks +59 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/routes.html View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/settings/settings_main/settings_main.html View 1 2 3 4 5 6 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/resources/settings/settings_resources.grd View 1 2 3 4 5 6 1 chunk +11 lines, -0 lines 0 comments Download
A chrome/browser/resources/settings/sync_page/sync_page.css View 1 2 3 4 5 1 chunk +22 lines, -0 lines 0 comments Download
A chrome/browser/resources/settings/sync_page/sync_page.html View 1 2 3 4 5 6 1 chunk +79 lines, -0 lines 0 comments Download
A + chrome/browser/resources/settings/sync_page/sync_page.js View 1 2 3 chunks +13 lines, -16 lines 0 comments Download
M chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc View 1 2 3 4 5 6 3 chunks +49 lines, -0 lines 0 comments Download
M ui/webui/resources/polymer_resources.grdp View 1 2 3 4 5 6 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (6 generated)
Kyle Horimoto
5 years, 6 months ago (2015-06-03 02:47:27 UTC) #2
James Hawkins
https://codereview.chromium.org/1159623003/diff/80001/chrome/app/settings_chromium_strings.grdp File chrome/app/settings_chromium_strings.grdp (right): https://codereview.chromium.org/1159623003/diff/80001/chrome/app/settings_chromium_strings.grdp#newcode8 chrome/app/settings_chromium_strings.grdp:8: Remove blank line. https://codereview.chromium.org/1159623003/diff/80001/chrome/app/settings_google_chrome_strings.grdp File chrome/app/settings_google_chrome_strings.grdp (right): https://codereview.chromium.org/1159623003/diff/80001/chrome/app/settings_google_chrome_strings.grdp#newcode8 chrome/app/settings_google_chrome_strings.grdp:8: ...
5 years, 6 months ago (2015-06-04 19:38:37 UTC) #3
Kyle Horimoto
https://codereview.chromium.org/1159623003/diff/80001/chrome/app/settings_chromium_strings.grdp File chrome/app/settings_chromium_strings.grdp (right): https://codereview.chromium.org/1159623003/diff/80001/chrome/app/settings_chromium_strings.grdp#newcode8 chrome/app/settings_chromium_strings.grdp:8: On 2015/06/04 19:38:37, James Hawkins wrote: > Remove blank ...
5 years, 6 months ago (2015-06-04 21:18:18 UTC) #4
James Hawkins
LGTM with request. https://codereview.chromium.org/1159623003/diff/100001/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc File chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc (right): https://codereview.chromium.org/1159623003/diff/100001/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc#newcode205 chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc:205: html_source->AddLocalizedString("okButton", Can you file a bug ...
5 years, 6 months ago (2015-06-04 22:17:12 UTC) #5
Kyle Horimoto
https://codereview.chromium.org/1159623003/diff/100001/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc File chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc (right): https://codereview.chromium.org/1159623003/diff/100001/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc#newcode205 chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc:205: html_source->AddLocalizedString("okButton", On 2015/06/04 22:17:12, James Hawkins wrote: > Can ...
5 years, 6 months ago (2015-06-04 22:47:45 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1159623003/100001
5 years, 6 months ago (2015-06-04 22:50:34 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_32_ng/builds/59767) ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 6 months ago (2015-06-04 22:56:33 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1159623003/120001
5 years, 6 months ago (2015-06-05 00:07:14 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/60290)
5 years, 6 months ago (2015-06-05 02:18:34 UTC) #15
commit-bot: I haz the power
Patchset 7 (id:??) landed as https://crrev.com/79f377603917b9f5c836158b27257a533b6dde35 Cr-Commit-Position: refs/heads/master@{#333077}
5 years, 6 months ago (2015-06-05 17:10:55 UTC) #16
Kyle Horimoto
5 years, 6 months ago (2015-06-05 17:11:04 UTC) #17
Message was sent while issue was closed. 
Committed patchset #7 (id:120001) manually as
79f377603917b9f5c836158b27257a533b6dde35 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698