Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4994)

Unified Diff: chrome/browser/resources/settings/sync_page/sync_page.js

Issue 1159623003: Add skeleton UI for sync page. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebased. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/sync_page/sync_page.js
diff --git a/chrome/browser/resources/settings/a11y_page/a11y_page.js b/chrome/browser/resources/settings/sync_page/sync_page.js
similarity index 64%
copy from chrome/browser/resources/settings/a11y_page/a11y_page.js
copy to chrome/browser/resources/settings/sync_page/sync_page.js
index 119f1c75a8eaff70e9f07325c2e7467d53b4823a..f671e1fdc8f49ad8bb648fe9d3b8331c9bfdbe4f 100644
--- a/chrome/browser/resources/settings/a11y_page/a11y_page.js
+++ b/chrome/browser/resources/settings/sync_page/sync_page.js
@@ -4,38 +4,34 @@
/**
* @fileoverview
- * 'cr-settings-a11y-page' is the settings page containing accessibility
- * settings.
+ * 'cr-settings-sync-page' is the settings page containing sync settings.
*
* Example:
*
* <iron-animated-pages>
- * <cr-settings-a11y-page prefs="{{prefs}}"></cr-settings-a11y-page>
+ * <cr-settings-sync-page></cr-settings-sync-page>
* ... other pages ...
* </iron-animated-pages>
*
* @group Chrome Settings Elements
- * @element cr-settings-a11y-page
+ * @element cr-settings-sync-page
*/
Polymer({
- is: 'cr-settings-a11y-page',
+ is: 'cr-settings-sync-page',
properties: {
/**
- * Preferences state.
- */
- prefs: {
- type: Object,
- notify: true,
- },
-
- /**
* Route for the page.
*/
- route: String,
+ route: {
+ type: String,
+ value: ''
+ },
/**
* Whether the page is a subpage.
+ * TODO(khorimoto): Make this a subpage once the "People" full page has
+ * landed, since this is supposed to be that page's subpage.
*/
subpage: {
type: Boolean,
@@ -48,7 +44,7 @@ Polymer({
*/
PAGE_ID: {
type: String,
- value: 'a11y',
+ value: 'sync',
readOnly: true,
},
@@ -57,11 +53,12 @@ Polymer({
*/
pageTitle: {
type: String,
- value: function() { return loadTimeData.getString('a11yPageTitle'); },
+ value: function() { return loadTimeData.getString('syncPageTitle'); },
},
/**
* Name of the 'iron-icon' to show.
+ * TODO(khorimoto): Find the correct icon to show.
*/
icon: {
type: String,

Powered by Google App Engine
This is Rietveld 408576698