Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Issue 1159563012: Add a deprecation message for multiple shadow roots. (Closed)

Created:
5 years, 6 months ago by hayato
Modified:
5 years, 6 months ago
Reviewers:
kochi
CC:
blink-reviews, webcomponents-bugzilla_chromium.org, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Add a deprecation message for multiple shadow roots. This CL also introduces a new UseCounter, ElementCreateShadowRootMultipleWithUserAgentShadwoRoot, to measure the usage separately. BUG=489947 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196057

Patch Set 1 #

Patch Set 2 : Rebase expectations #

Patch Set 3 : Use another UserCounter for an user-agent shadow root. #

Patch Set 4 : Change a deprecation message #

Patch Set 5 : Rebase UseCounter.h #

Total comments: 2

Patch Set 6 : Rebase more expectations. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -3 lines) Patch
M LayoutTests/editing/shadow/selection-all-with-shadow-expected.txt View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/editing/shadow/selection-of-shadowroot-expected.txt View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/editing/spelling/spellcheck-author-shadow-crash-expected.txt View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/editing/text-iterator/findString-shadow-roots-expected.txt View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/dom/shadow/composed-shadow-tree-walker-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/dom/shadow/composed-shadow-tree-walker-shadow-reprojection-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/dom/shadow/content-pseudo-element-with-deep-combinator-and-host-pseudo-class-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/dom/shadow/content-pseudo-element-with-shadow-pseudo-element-and-host-pseudo-class-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/dom/shadow/css-focus-pseudo-match-shadow-host-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/dom/shadow/distribution-crash-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/dom/shadow/event-path-empty-shadow-element-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/dom/shadow/event-path-multiple-shadow-roots-2-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/dom/shadow/event-path-multiple-shadow-roots-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/dom/shadow/event-path-shadow-insertion-point-in-oldest-shadow-root-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/dom/shadow/events-stopped-at-shadow-boundary-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/dom/shadow/focus-navigation-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/dom/shadow/focus-navigation-with-multiple-shadow-roots-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/dom/shadow/get-destination-insertion-points-shadow-insertion-points-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/dom/shadow/get-element-by-id-in-shadow-root-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/dom/shadow/has-content-elements-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/dom/shadow/has-elementshadow-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/dom/shadow/has-shadow-insertion-point-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/dom/shadow/hostcontext-pseudo-class-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/dom/shadow/insertion-point-list-menu-crash-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/dom/shadow/insertion-point-shadow-crash-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/dom/shadow/insertion-point-video-crash-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/dom/shadow/move-style-scoped-to-another-shadowroot-crash-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/dom/shadow/multiple-shadowroot-adopt-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/dom/shadow/multiple-shadowroot-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/dom/shadow/multiple-shadowroot-rendering-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/dom/shadow/nested-reprojection-inconsistent-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/dom/shadow/olderShadowRoot-expected.txt View 1 2 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/fast/dom/shadow/parent-tree-scope-in-shadow-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/dom/shadow/querySelector-for-multiple-shadowroots-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/dom/shadow/selections-in-shadow-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/dom/shadow/shadow-aware-create-shadow-root-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/dom/shadow/shadow-aware-shadow-root-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/dom/shadow/shadow-disable-expected.txt View 1 2 4 5 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/dom/shadow/shadow-dom-event-dispatching-distributed-to-younger-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/dom/shadow/shadow-dom-event-dispatching-empty-shadow-element-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/dom/shadow/shadow-dom-event-dispatching-multiple-shadow-roots-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/dom/shadow/shadow-dom-event-dispatching-non-distributed-nodes-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/dom/shadow/shadow-element-distributed-nodes-expected.txt View 1 2 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/fast/dom/shadow/shadow-element-inactive-expected.txt View 1 2 4 5 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/dom/shadow/shadow-element-rendering-multiple-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/dom/shadow/shadow-reprojection-click-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/dom/shadow/shadow-root-js-api-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/dom/shadow/shadow-select-attribute-featureset-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/dom/shadow/shadow-selection-detach-crash-expected.txt View 1 2 4 5 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/dom/shadow/shadowdom-for-form-associated-element-useragent-expected.txt View 1 2 4 5 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/dom/shadow/shadowdom-for-input-button-click-expected.txt View 1 2 4 5 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/dom/shadow/shadowdom-for-input-color-expected.txt View 1 2 4 5 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/dom/shadow/shadowdom-for-input-file-expected.txt View 1 2 4 5 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/dom/shadow/shadowdom-for-input-range-expected.txt View 1 2 4 5 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/dom/shadow/shadowdom-for-input-spellcheck-expected.txt View 1 2 4 5 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/dom/shadow/shadowdom-for-input-type-change-expected.txt View 1 2 4 5 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/dom/shadow/shadowdom-for-media-expected.txt View 1 2 4 5 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/dom/shadow/shadowroot-host-expected.txt View 1 2 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/fast/dom/shadow/stale-distribution-after-shadow-removal-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/dom/shadow/style-and-shadow-element-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/dom/shadow/style-sharing-styles-in-older-shadow-roots-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/dom/shadow/style-with-deep-combinator-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/dom/shadow/style-with-shadow-pseudo-element-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/dom/shadow/text-node-distributed-crash-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/dom/shadow/tooltips-in-shadow-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/selectors/style-sharing-shadow-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/inspector/elements/create-shadow-root-expected.txt View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/inspector/elements/shadow-host-display-modes-expected.txt View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/dom/shadow/ElementShadow.cpp View 1 2 1 chunk +7 lines, -3 lines 0 comments Download
M Source/core/frame/UseCounter.h View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/frame/UseCounter.cpp View 1 2 4 5 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
hayato
PTAL
5 years, 6 months ago (2015-05-28 03:18:54 UTC) #2
kochi
Please fix remaining layout test failures. https://codereview.chromium.org/1159563012/diff/80001/Source/core/frame/UseCounter.cpp File Source/core/frame/UseCounter.cpp (right): https://codereview.chromium.org/1159563012/diff/80001/Source/core/frame/UseCounter.cpp#newcode907 Source/core/frame/UseCounter.cpp:907: return "Calling Element.createShadowRoot() ...
5 years, 6 months ago (2015-05-28 04:19:45 UTC) #3
hayato
Rebased more expectations. PTAL. https://codereview.chromium.org/1159563012/diff/80001/Source/core/frame/UseCounter.cpp File Source/core/frame/UseCounter.cpp (right): https://codereview.chromium.org/1159563012/diff/80001/Source/core/frame/UseCounter.cpp#newcode907 Source/core/frame/UseCounter.cpp:907: return "Calling Element.createShadowRoot() for an ...
5 years, 6 months ago (2015-05-28 11:55:41 UTC) #4
kochi
lgtm
5 years, 6 months ago (2015-05-28 12:43:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1159563012/100001
5 years, 6 months ago (2015-05-28 12:43:40 UTC) #7
commit-bot: I haz the power
5 years, 6 months ago (2015-05-28 12:48:02 UTC) #8
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196057

Powered by Google App Engine
This is Rietveld 408576698