Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(835)

Side by Side Diff: Source/core/frame/UseCounter.cpp

Issue 1159563012: Add a deprecation message for multiple shadow roots. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebase UseCounter.h Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/frame/UseCounter.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google, Inc. All rights reserved. 2 * Copyright (C) 2012 Google, Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 882 matching lines...) Expand 10 before | Expand all | Expand 10 after
893 893
894 case EncryptedMediaInsecureOrigin: 894 case EncryptedMediaInsecureOrigin:
895 return "requestMediaKeySystemAccess() is deprecated on insecure origins in the specification. Support will be removed in the future. You should consider switching your application to a secure origin, such as HTTPS. See https://goo.g l/rStTGz for more details."; 895 return "requestMediaKeySystemAccess() is deprecated on insecure origins in the specification. Support will be removed in the future. You should consider switching your application to a secure origin, such as HTTPS. See https://goo.g l/rStTGz for more details.";
896 896
897 case PushSubscriptionId: 897 case PushSubscriptionId:
898 return "'PushSubscription.subscriptionId' is deprecated and is now inclu ded in 'PushSubscription.endpoint'. It will be removed in Chrome 45, around Augu st 2015."; 898 return "'PushSubscription.subscriptionId' is deprecated and is now inclu ded in 'PushSubscription.endpoint'. It will be removed in Chrome 45, around Augu st 2015.";
899 899
900 case DocumentGetCSSCanvasContext: 900 case DocumentGetCSSCanvasContext:
901 return "The -webkit-canvas CSS feature is deprecated. Please use a posit ioned <canvas> element instead."; 901 return "The -webkit-canvas CSS feature is deprecated. Please use a posit ioned <canvas> element instead.";
902 902
903 case ElementCreateShadowRootMultiple:
904 return "Calling Element.createShadowRoot() for an element which already hosts a shadow root is deprecated. See https://www.chromestatus.com/features/466 8884095336448 for more details.";
905
906 case ElementCreateShadowRootMultipleWithUserAgentShadowRoot:
907 return "Calling Element.createShadowRoot() for an element which already hosts an user-agent shadow root is deprecated. See https://www.chromestatus.com/ features/4668884095336448 for more details.";
kochi 2015/05/28 04:19:44 nit: "a" user-agent
hayato 2015/05/28 11:55:41 Done.
908
903 // Features that aren't deprecated don't have a deprecation message. 909 // Features that aren't deprecated don't have a deprecation message.
904 default: 910 default:
905 return String(); 911 return String();
906 } 912 }
907 } 913 }
908 914
909 void UseCounter::count(CSSParserContext context, CSSPropertyID feature) 915 void UseCounter::count(CSSParserContext context, CSSPropertyID feature)
910 { 916 {
911 ASSERT(feature >= firstCSSProperty); 917 ASSERT(feature >= firstCSSProperty);
912 ASSERT(feature <= lastUnresolvedCSSProperty); 918 ASSERT(feature <= lastUnresolvedCSSProperty);
(...skipping 27 matching lines...) Expand all
940 UseCounter* UseCounter::getFrom(const StyleSheetContents* sheetContents) 946 UseCounter* UseCounter::getFrom(const StyleSheetContents* sheetContents)
941 { 947 {
942 // FIXME: We may want to handle stylesheets that have multiple owners 948 // FIXME: We may want to handle stylesheets that have multiple owners
943 // http://crbug.com/242125 949 // http://crbug.com/242125
944 if (sheetContents && sheetContents->hasSingleOwnerNode()) 950 if (sheetContents && sheetContents->hasSingleOwnerNode())
945 return getFrom(sheetContents->singleOwnerDocument()); 951 return getFrom(sheetContents->singleOwnerDocument());
946 return 0; 952 return 0;
947 } 953 }
948 954
949 } // namespace blink 955 } // namespace blink
OLDNEW
« no previous file with comments | « Source/core/frame/UseCounter.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698