Issue 1159563002: Move retry and lhttp packages from client/internal to common/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1159563002: Move retry and lhttp packages from client/internal to common/. (Closed)

Created:
5 years, 7 months ago by Vadim Sh.

Modified:
5 years, 6 months ago

Reviewers:
M-A Ruel

CC:
chromium-reviews, todd, andrew.wang, M-A Ruel, tandrii(chromium)

Base URL:
git@github.com:luci/luci-go@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Move retry and lhttp packages from client/internal to common/. They are written and reusable way and can be helpful outside the client too (e.g in common/auth/service.go and in infra.git). R=maruel@chromium.org BUG=

Patch Set 1 : move-retry-http #

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+5 lines, -682 lines)			Patch
M	client/cmd/isolate/common.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	client/cmd/isolated/common.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	client/cmd/swarming/common.go	View	1 chunk	+1 line, -1 line	0 comments	Download
D	client/internal/lhttp/client.go	View	1 chunk	+0 lines, -191 lines	0 comments	Download
D	client/internal/lhttp/client_test.go	View	1 chunk	+0 lines, -275 lines	0 comments	Download
D	client/internal/lhttp/doc.go	View	1 chunk	+0 lines, -9 lines	0 comments	Download
D	client/internal/lhttp/utils.go	View	1 chunk	+0 lines, -29 lines	0 comments	Download
D	client/internal/lhttp/utils_test.go	View	1 chunk	+0 lines, -29 lines	0 comments	Download
D	client/internal/retry/doc.go	View	1 chunk	+0 lines, -8 lines	0 comments	Download
D	client/internal/retry/retry.go	View	1 chunk	+0 lines, -66 lines	0 comments	Download
D	client/internal/retry/retry_test.go	View	1 chunk	+0 lines, -70 lines	0 comments	Download
M	client/isolatedclient/isolatedclient.go	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	client/swarming/swarming.go	View	1 chunk	+2 lines, -2 lines	0 comments	Download
A +	common/lhttp/client.go	View	1 chunk	+1 line, -1 line	0 comments	Download
A +	common/lhttp/client_test.go	View	1 chunk	+1 line, -1 line	0 comments	Download
A +	common/lhttp/doc.go	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	common/lhttp/utils.go	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	common/lhttp/utils_test.go	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	common/retry/doc.go	View	1 chunk	+1 line, -1 line	0 comments	Download
A +	common/retry/retry.go	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	common/retry/retry_test.go	View	0 chunks	+-1 lines, --1 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages