Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Issue 1159493007: Refactor word splitting in gles2 command generator (Closed)

Created:
5 years, 6 months ago by mkollaro
Modified:
5 years, 6 months ago
CC:
chromium-reviews, piman+watch_chromium.org, zmo
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Refactor word splitting in gles2 command generator BUG=None Committed: https://crrev.com/10b6f828beb3efff6e2e7306280111836a6bc9c0 Cr-Commit-Position: refs/heads/master@{#332165}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -23 lines) Patch
M gpu/command_buffer/build_gles2_cmd_buffer.py View 2 chunks +7 lines, -23 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
mkollaro
5 years, 6 months ago (2015-05-29 12:44:26 UTC) #2
bajones
LGTM. I appreciate clearing up when the lower casing actually happens, thanks. +zmo@ as an ...
5 years, 6 months ago (2015-05-30 00:14:24 UTC) #4
Zhenyao Mo
On 2015/05/30 00:14:24, bajones(OOO-parental_leave) wrote: > LGTM. I appreciate clearing up when the lower casing ...
5 years, 6 months ago (2015-05-30 00:55:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1159493007/1
5 years, 6 months ago (2015-06-01 06:54:25 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-01 07:04:59 UTC) #8
commit-bot: I haz the power
5 years, 6 months ago (2015-06-01 07:06:21 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/10b6f828beb3efff6e2e7306280111836a6bc9c0
Cr-Commit-Position: refs/heads/master@{#332165}

Powered by Google App Engine
This is Rietveld 408576698