src/json-parser.h - Issue 1159433003: Use GetProperty for getting elements.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/json-parser.h

Issue 1159433003: Use GetProperty for getting elements. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Addressed comments Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/json-parser.h

diff --git a/src/json-parser.h b/src/json-parser.h

index b5dc33eb5713bd521444370c5de7fbd7017c3e5e..973e9a0fe3b279cc79bb9fab9c2a8a66824489de 100644

--- a/src/json-parser.h

+++ b/src/json-parser.h

@@ -311,7 +311,7 @@ ParseElementResult JsonParser<seq_one_byte>::ParseElement(

} else {

do {

int d = c0_ - '0';

- if (index > 429496729U - ((d > 5) ? 1 : 0)) break;

+ if (index > 429496729U - ((d + 3) >> 3)) break;

index = (index * 10) + d;

Advance();

} while (IsDecimalDigit(c0_));

« no previous file with comments | « src/ic/ic.cc ('k') | src/json-stringifier.h » ('j') | no next file with comments »