Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 1159403005: bindings: Use IDL dictionary to implement FontFaceSetLoadEventInit (Closed)

Created:
5 years, 6 months ago by bashi
Modified:
5 years, 6 months ago
CC:
blink-reviews, arv+blink, vivekg_samsung, blink-reviews-css, eae+blinkwatch, vivekg, dglazkov+blink, blink-reviews-events_chromium.org, blink-reviews-bindings_chromium.org, Inactive, darktears, apavlov+blink_chromium.org, rwlbuis
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

bindings: Use IDL dictionary to implement FontFaceSetLoadEventInit This CL also adds an empty array default value ("[]") in IDL dictionary as FontFaceSetLoadEventInit requires it. BUG=433179 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196296

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+117 lines, -8 lines) Patch
M Source/bindings/scripts/v8_types.py View 1 chunk +14 lines, -0 lines 0 comments Download
M Source/bindings/tests/idls/core/TestDictionary.idl View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/bindings/tests/results/core/TestDictionary.h View 4 chunks +15 lines, -0 lines 0 comments Download
M Source/bindings/tests/results/core/TestDictionary.cpp View 2 chunks +5 lines, -0 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestDictionary.cpp View 6 chunks +72 lines, -0 lines 0 comments Download
M Source/core/core.gypi View 2 chunks +3 lines, -0 lines 0 comments Download
M Source/core/css/FontFaceSetLoadEvent.h View 2 chunks +1 line, -4 lines 0 comments Download
M Source/core/css/FontFaceSetLoadEvent.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/css/FontFaceSetLoadEventInit.idl View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
bashi
PTAL? Since FontFaceSetLoadEvent is [NoInterfaceObject] we don't have any layout tests for the constructor. Per ...
5 years, 6 months ago (2015-06-02 04:59:17 UTC) #2
haraken
LGTM
5 years, 6 months ago (2015-06-02 05:09:22 UTC) #3
Kunihiko Sakamoto
core/css lgtm
5 years, 6 months ago (2015-06-02 05:15:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1159403005/1
5 years, 6 months ago (2015-06-02 05:21:49 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-02 08:15:28 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196296

Powered by Google App Engine
This is Rietveld 408576698